[GitHub] [doris] wangbo commented on a diff in pull request #10695: [BUG](datev2) fix bloom filter for datev2 and remove redundant code

[GitBox <gi...@apache.org>]

wangbo commented on code in PR #10695:
URL: https://github.com/apache/doris/pull/10695#discussion_r916723622


##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -960,13 +960,6 @@ void DefaultValueColumnIterator::insert_default_data(const TypeInfo* type_info,
         dst->insert_many_data(data_ptr, data_len, n);
         break;
     }
-    case OLAP_FIELD_TYPE_DATEV2: {
-        assert(type_size == sizeof(FieldTypeTraits<OLAP_FIELD_TYPE_DATEV2>::CppType)); //uint32_t
-
-        int128 = *((FieldTypeTraits<OLAP_FIELD_TYPE_DATEV2>::CppType*)mem_value);
-        dst->insert_many_data(data_ptr, data_len, n);
-        break;

Review Comment:
   Why here is removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org