You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/11/26 16:28:07 UTC
[GitHub] incubator-brooklyn pull request: Type registry - validation and al...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1073
Type registry - validation and aliases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn type-registry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1073
----
commit 061d70d43dd5f1d7edaa3403024818cde0f021c8
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-11-26T08:45:19Z
introduce VersionComparator and use it where appropriate
in prep for RegisteredType best version support
commit 421c8849121c5b81a2e5b5a9b6d27192d018e959
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-11-26T10:04:02Z
type registry: adds validation, best version support, aliases, tags
and a simple registry with lookup tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Type registry - validation and al...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Type registry - validation and al...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Type registry - validation and al...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1073#issuecomment-165462072
@neykov All addressed. I rebased which has lost your comments on this PR :( but they were all good ones and you'll see my notes on email.
Only thing to call out is the introduction and use of `Maybe.isNull()`. It allows us to speak of absent nulls which i think is a good thing. See the creation methods on `Maybe` for more info. /cc @aledsage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Type registry - validation and al...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1073#issuecomment-161621581
Looks good. Very minor comments to address and some others to respond to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Type registry - validation and al...
Posted by ahgittin <gi...@git.apache.org>.
GitHub user ahgittin reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1073
Type registry - validation and aliases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn type-registry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1073
----
commit 061d70d43dd5f1d7edaa3403024818cde0f021c8
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-11-26T08:45:19Z
introduce VersionComparator and use it where appropriate
in prep for RegisteredType best version support
commit 421c8849121c5b81a2e5b5a9b6d27192d018e959
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-11-26T10:04:02Z
type registry: adds validation, best version support, aliases, tags
and a simple registry with lookup tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Type registry - validation and al...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1073#issuecomment-160089111
The build failure at https://builds.apache.org/job/incubator-brooklyn-pull-requests/2248/ is a problem with the Apache build system :( . Closing and reopening to trigger new build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---