You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/05 07:11:18 UTC
[GitHub] [hudi] n3nash commented on a change in pull request #2129: [HUDI-1302] Add support for timestamp field in HiveSync
n3nash commented on a change in pull request #2129:
URL: https://github.com/apache/hudi/pull/2129#discussion_r499383876
##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HiveSchemaUtil.java
##########
@@ -167,7 +173,10 @@ private static String convertField(final Type parquetType) {
.append(decimalMetadata.getScale()).append(")").toString();
} else if (originalType == OriginalType.DATE) {
return field.append("DATE").toString();
+ } else if (supportTimestamp && originalType == OriginalType.TIMESTAMP_MICROS) {
Review comment:
Could you please explain what happens now if the originalType == `OriginalType.TIMESTAMP_MICROS` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org