You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/06/11 10:03:02 UTC
[jira] [Commented] (YARN-3794) TestRMEmbeddedElector fails because
of ambiguous LOG reference
[ https://issues.apache.org/jira/browse/YARN-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581637#comment-14581637 ]
Hadoop QA commented on YARN-3794:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 6m 30s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 35s | There were no new javac warning messages. |
| {color:green}+1{color} | release audit | 0m 19s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 46s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install | 1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 24s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests | 50m 49s | Tests failed in hadoop-yarn-server-resourcemanager. |
| | | 69m 33s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12738994/YARN-3794.01.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 95c73d4 |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8236/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8236/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8236/console |
This message was automatically generated.
> TestRMEmbeddedElector fails because of ambiguous LOG reference
> --------------------------------------------------------------
>
> Key: YARN-3794
> URL: https://issues.apache.org/jira/browse/YARN-3794
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Affects Versions: 2.7.0
> Reporter: Chengbing Liu
> Assignee: Chengbing Liu
> Attachments: YARN-3794.01.patch
>
>
> After YARN-2921, {{MockRM}} has also a {{LOG}} field. Therefore {{LOG}} in the following code snippet is ambiguous.
> {code}
> protected AdminService createAdminService() {
> return new AdminService(MockRMWithElector.this, getRMContext()) {
> @Override
> protected EmbeddedElectorService createEmbeddedElectorService() {
> return new EmbeddedElectorService(getRMContext()) {
> @Override
> public void becomeActive() throws
> ServiceFailedException {
> try {
> callbackCalled.set(true);
> LOG.info("Callback called. Sleeping now");
> Thread.sleep(delayMs);
> LOG.info("Sleep done");
> } catch (InterruptedException e) {
> e.printStackTrace();
> }
> super.becomeActive();
> }
> };
> }
> };
> }
> {code}
> Eclipse gives the following error:
> {quote}
> The field LOG is defined in an inherited type and an enclosing scope
> {quote}
> IMO, we should fix this as {{TestRMEmbeddedElector.LOG}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)