You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/02 18:57:23 UTC
[GitHub] [kafka] ivanyu opened a new pull request, #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
ivanyu opened a new pull request, #13065:
URL: https://github.com/apache/kafka/pull/13065
This is a relatively independent change in the context of KAFKA-14482.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #13065:
URL: https://github.com/apache/kafka/pull/13065#discussion_r1061302703
##########
storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
+
+import java.util.Objects;
+
+public class LoadedLogOffsets {
+ public final long logStartOffset;
+ public final long recoveryPoint;
+ public final LogOffsetMetadata nextOffsetMetadata;
+
+ public LoadedLogOffsets(final long logStartOffset,
+ final long recoveryPoint,
+ final LogOffsetMetadata nextOffsetMetadata) {
+ this.logStartOffset = logStartOffset;
+ this.recoveryPoint = recoveryPoint;
+ this.nextOffsetMetadata = nextOffsetMetadata;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ final LoadedLogOffsets that = (LoadedLogOffsets) o;
+ return logStartOffset == that.logStartOffset
+ && recoveryPoint == that.recoveryPoint
+ && Objects.equals(nextOffsetMetadata, that.nextOffsetMetadata);
Review Comment:
`nextOffsetMetadata` is never null, so we don't need the `Objects.equals` call. We can perhaps enforce in the constructor for clarity.
##########
storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
+
+import java.util.Objects;
+
+public class LoadedLogOffsets {
+ public final long logStartOffset;
+ public final long recoveryPoint;
+ public final LogOffsetMetadata nextOffsetMetadata;
+
+ public LoadedLogOffsets(final long logStartOffset,
+ final long recoveryPoint,
+ final LogOffsetMetadata nextOffsetMetadata) {
+ this.logStartOffset = logStartOffset;
+ this.recoveryPoint = recoveryPoint;
+ this.nextOffsetMetadata = nextOffsetMetadata;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ final LoadedLogOffsets that = (LoadedLogOffsets) o;
+ return logStartOffset == that.logStartOffset
+ && recoveryPoint == that.recoveryPoint
+ && Objects.equals(nextOffsetMetadata, that.nextOffsetMetadata);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(logStartOffset, recoveryPoint, nextOffsetMetadata);
Review Comment:
To avoid unnecessary garbage, we should avoid the `Objects.hash` call (which results in boxing for each `long` and the array allocation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #13065:
URL: https://github.com/apache/kafka/pull/13065#discussion_r1061339081
##########
storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
+
+import java.util.Objects;
+
+public class LoadedLogOffsets {
+ public final long logStartOffset;
+ public final long recoveryPoint;
+ public final LogOffsetMetadata nextOffsetMetadata;
+
+ public LoadedLogOffsets(final long logStartOffset,
+ final long recoveryPoint,
+ final LogOffsetMetadata nextOffsetMetadata) {
+ this.logStartOffset = logStartOffset;
+ this.recoveryPoint = recoveryPoint;
+ this.nextOffsetMetadata = nextOffsetMetadata;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ final LoadedLogOffsets that = (LoadedLogOffsets) o;
+ return logStartOffset == that.logStartOffset
+ && recoveryPoint == that.recoveryPoint
+ && Objects.equals(nextOffsetMetadata, that.nextOffsetMetadata);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(logStartOffset, recoveryPoint, nextOffsetMetadata);
+ }
+
+ @Override
+ public String toString() {
+ return "LoadedLogOffsetsNew(" +
Review Comment:
"LoadedLogOffsetsNew" -> please remove the "New" from the String representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ivanyu commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
ivanyu commented on code in PR #13065:
URL: https://github.com/apache/kafka/pull/13065#discussion_r1061595160
##########
storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
+
+import java.util.Objects;
+
+public class LoadedLogOffsets {
+ public final long logStartOffset;
+ public final long recoveryPoint;
+ public final LogOffsetMetadata nextOffsetMetadata;
+
+ public LoadedLogOffsets(final long logStartOffset,
+ final long recoveryPoint,
+ final LogOffsetMetadata nextOffsetMetadata) {
+ this.logStartOffset = logStartOffset;
+ this.recoveryPoint = recoveryPoint;
+ this.nextOffsetMetadata = nextOffsetMetadata;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ final LoadedLogOffsets that = (LoadedLogOffsets) o;
+ return logStartOffset == that.logStartOffset
+ && recoveryPoint == that.recoveryPoint
+ && Objects.equals(nextOffsetMetadata, that.nextOffsetMetadata);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(logStartOffset, recoveryPoint, nextOffsetMetadata);
+ }
+
+ @Override
+ public String toString() {
+ return "LoadedLogOffsetsNew(" +
Review Comment:
Sorry, missed during renaming. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ivanyu commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
ivanyu commented on code in PR #13065:
URL: https://github.com/apache/kafka/pull/13065#discussion_r1061598386
##########
storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
+
+import java.util.Objects;
+
+public class LoadedLogOffsets {
+ public final long logStartOffset;
+ public final long recoveryPoint;
+ public final LogOffsetMetadata nextOffsetMetadata;
+
+ public LoadedLogOffsets(final long logStartOffset,
+ final long recoveryPoint,
+ final LogOffsetMetadata nextOffsetMetadata) {
+ this.logStartOffset = logStartOffset;
+ this.recoveryPoint = recoveryPoint;
+ this.nextOffsetMetadata = nextOffsetMetadata;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ final LoadedLogOffsets that = (LoadedLogOffsets) o;
+ return logStartOffset == that.logStartOffset
+ && recoveryPoint == that.recoveryPoint
+ && Objects.equals(nextOffsetMetadata, that.nextOffsetMetadata);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(logStartOffset, recoveryPoint, nextOffsetMetadata);
Review Comment:
Yes, valid point. I replaced it with an explicit implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ivanyu commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
ivanyu commented on code in PR #13065:
URL: https://github.com/apache/kafka/pull/13065#discussion_r1061598967
##########
storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
+
+import java.util.Objects;
+
+public class LoadedLogOffsets {
+ public final long logStartOffset;
+ public final long recoveryPoint;
+ public final LogOffsetMetadata nextOffsetMetadata;
+
+ public LoadedLogOffsets(final long logStartOffset,
+ final long recoveryPoint,
+ final LogOffsetMetadata nextOffsetMetadata) {
+ this.logStartOffset = logStartOffset;
+ this.recoveryPoint = recoveryPoint;
+ this.nextOffsetMetadata = nextOffsetMetadata;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ final LoadedLogOffsets that = (LoadedLogOffsets) o;
+ return logStartOffset == that.logStartOffset
+ && recoveryPoint == that.recoveryPoint
+ && Objects.equals(nextOffsetMetadata, that.nextOffsetMetadata);
Review Comment:
I see. Did as you suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ivanyu commented on pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
ivanyu commented on PR #13065:
URL: https://github.com/apache/kafka/pull/13065#issuecomment-1369155807
@ijuma @satishd if you happen to have a minute, please have a look (tagging you since you're active on similar/related tickets).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd commented on pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
satishd commented on PR #13065:
URL: https://github.com/apache/kafka/pull/13065#issuecomment-1371669507
Failing test does not seem to be related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd merged pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module
Posted by GitBox <gi...@apache.org>.
satishd merged PR #13065:
URL: https://github.com/apache/kafka/pull/13065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org