You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/06 07:48:18 UTC
[GitHub] [skywalking-client-js] Fine0830 commented on a diff in pull request #79: fix: update fmp metric
Fine0830 commented on code in PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79#discussion_r843597693
##########
src/trace/type.d.ts:
##########
@@ -28,8 +28,8 @@ export interface SpanFields {
startTime: number;
endTime: number;
spanId: number;
- spanLayer: number;
- spanType: number;
+ spanLayer: string;
+ spanType: string;
Review Comment:
> Are these working for the HTTP span receiver? FYI @arugal
Yes, I have checked the protocol https://github.com/apache/skywalking/blob/master/docs/en/protocols/Trace-Data-Protocol-v3.md. And I found the mistake from https://github.com/apache/skywalking-client-js/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org