[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3979: Track "freshness" timestamp across consuming segments

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #3979: Track "freshness" timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r280647610
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/stream/MessageBatch.java
 ##########
 @@ -62,9 +63,9 @@
    * when the message was ingested by the upstream stream-provider and other relevant metadata.
    *
    */
-  default void getMetadataAtIndex(int index, StreamMessageMetadata metadata) {
+  default RowMetadata getMetadataAtIndex(int index) {
     // update metadata as required - default implementation does nothing
 
 Review comment:
   Please update the comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org