You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/05/31 17:47:59 UTC
[Apache Bloodhound] #94: Activity area to automatically filter to
show entries relevant for the view
#94: Activity area to automatically filter to show entries relevant for the view
-------------------------+--------------------
Reporter: gjm | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone:
Component: dashboard | Version:
Keywords: |
-------------------------+--------------------
The activity area, being a feature that is shared between the different
dashboard views including (may not be exhaustive)
* top level dashboard,
* product,
* version,
* milestone,
* component,
* ticket
should auto filter to show the events associated with that level and
entities understood to be a part of them. So, for example, the activity
area for a version should show all events for all associated milestones,
components, tickets and commits against tickets.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by gjm):
Closing as fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by gjm):
r1386610 commits the product_resource and product_context patches with
fixes
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by olemis):
Two more patches submitted few minutes ago. They implement resource
manager interface for products and ensure product web context is included
when rendering product pages . That's everything needed to add support to
filter ticket events in product view . Nonetheless , considering the fact
that more resources are associated to products (e.g. changesets, wiki
pages , ... indeed all kinds of resources ''';)''' this is just an initial
implementation of this feature. Besides , they should be updated once #110
will be implemented .
Patches for multiproduct plugin should be applied against r1354893 in the
following order :
{{{
#!sh
$ hg qapplied
t94/t94_r1354893_product_resources.diff
t94/t94_r1354893_product_context.diff
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by olemis):
Attached patches filter timeline according to resource set in active
rendering context.
==== Dashboard ====
attachment:t94_r1362098_timeline_filters_api.diff is the most important
patch. It introduces two important enhamcements . Firstly , it ensures
that the widget is rendered in the same context of the target view. This
implies some minor changes in dashboard and widgets API consisting in
mainly using a `RenderingContext` object instead of a web `Request` and
also propagation of the former through a path starting from view/template
code until it finally gets processed by core widget rendering engine. In
second place , it adds a whole new API to filter timeline events. In order
to make it work without patching ''Trac'' source code it was necessary to
override parts of the timeline engine in non-trivial ways . That's mainly
why it took so long to figure this out . Please consider reviewing all
this . My only suggestion would be to '''move the whole timeline filters
infrastructure onto a new module''' (e.g. `bhdashboard.timeline`) in order
to allow for reusing it beyond activity widget source code.
The other two patches implement the code needed to only show relevant
ticket events in milestone view. They should be applied in the following
order
{{{
#!sh
$ hg qapplied
t94/t94_r1362098_timeline_filters_api.diff
t94/t94_r1362098_timeline_filter_ticket_field.diff
t94/t94_r1362098_filter_activity.diff
}}}
The solution is generic enough and may be reused in other scenarios for
models associated to tickets via ticket fields. Two remarkable examples
are version pages (i.e. #109) and product view . The filter currently
relies on existing resources API to do its job. That means that afaics '''
`IResourceManager` interface must be implemented for both products and
versions'''. After that work needed to upgrade activity feed is relatively
simple. Should a new ticket be created in order to implement products and
versions resource manager?
Finally , installer has to enable filter components at installation time
in order to make all this magic happen .
==== Theme ====
Just a super tiny patch in attachment:t94_r1361192_milestone_typo.diff
I look forward to your comments .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Changes (by olemis):
* status: new => accepted
* owner: nobody => olemis
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by gjm):
r1383477 applies timeline filters api patch
r1383482 applies timeline filter ticket field and filter activity patches
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Changes (by gjm):
* status: accepted => assigned
* owner: olemis => gjm
Comment:
Assigning to myself for review
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by gjm):
r1386655 fixes it so that tickets are also able to take advantage of the
filtering
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Changes (by olemis):
* milestone: => Release 2
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by gjm):
Two missing imports seemed to be required to get the multiproduct patches
working:
* In {{{t94_r1354893_product_resources.diff}}} '{{{_}}}' on line 31:
{{{
#!python
from trac.util.translation import _, N_
}}}
* In {{{t94_r1354893_product_context.diff}}} '{{{Resource}}}' on line 29:
{{{
#!python
from trac.resource import Resource, ResourceNotFound
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #94: Activity area to automatically filter
to show entries relevant for the view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#94: Activity area to automatically filter to show entries relevant for the view
--------------------------+-----------------------
Reporter: gjm | Owner: gjm
Type: enhancement | Status: closed
Priority: major | Milestone: Release 2
Component: dashboard | Version:
Resolution: fixed | Keywords:
--------------------------+-----------------------
Changes (by gjm):
* status: assigned => closed
* resolution: => fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/94#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker