[jira] [Commented] (KAFKA-6265) GlobalKTable missing #queryableStoreName()

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287230#comment-16287230 ] 

Guozhang Wang commented on KAFKA-6265:
--------------------------------------

Note that {{GlobalKTableImpl}} is only constructed in {{InternalStreamsBuilder#globalTable}} (the other caller is a deprecated one and would be removed in the future) with a single store name passed from {{storeBuilder}}, so its {{KTableSourceValueGetterSupplier#storeNames()}} should always return a single store name passed in by the {{storeBuilder}}.

Now we can take a look at which values should we return when adding this {{queryableStoreName}}, similar to {{KTable}} there are two cases:

1) users do not provide a store name when specifying {{Materialized}} or they do not a {{Materialized}} object at all in the other overloading {{globalTable}} function. In this case the library will auto generate a store name {{storeName = nameProvider.newStoreName(generatedStorePrefix);}} which is only used as a place holder for internal usage and hence should not be exposed in {{queryableStoreName}}, instead we should return {{null}} indicating that this store is not queryable.

2) users do provide a store name when building the topology, in this case we should make sure that this store name is made to the {{storeBuilder}} (I think we already do, but worth double checking all the call traces) and hence can be returned in {{queryableStoreName}}.

> GlobalKTable missing #queryableStoreName()
> ------------------------------------------
>
>                 Key: KAFKA-6265
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6265
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Antony Stubbs
>              Labels: beginner, needs-kip, newbie
>
> KTable has the nicely useful #queryableStoreName(), it seems to be missing from GlobalKTable



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)