You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/19 20:19:05 UTC
[jira] [Commented] (NIFI-1046) clean up shell scripts
[ https://issues.apache.org/jira/browse/NIFI-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963721#comment-14963721 ]
ASF GitHub Bot commented on NIFI-1046:
--------------------------------------
GitHub user technmsg opened a pull request:
https://github.com/apache/nifi/pull/106
NIFI-1046 clean up shell scripts
Didn't squash specifically to ease review what was changed in each pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/technmsg/nifi patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 5dcebf3aae64e6d564b3e76372b942045b1da9f7
Author: Alex Moundalexis <al...@cloudera.com>
Date: 2015-10-19T17:42:28Z
shell clean up: remove backticks from nifi.sh
commit 909faa59d2002b16a734a8dcad32e04a99cd9b11
Author: Alex Moundalexis <al...@cloudera.com>
Date: 2015-10-19T18:02:39Z
shell clean up: quoting prevents globbing & word splitting
Ignoring the unquoted array expansions on L188/190; suspect they ought to be quoted per [SC2068](https://github.com/koalaman/shellcheck/wiki/SC2068), but need to confirm desired arguments.
commit 7f3b38324398336f47e2179796014f7e6c7c52dd
Author: Alex Moundalexis <al...@cloudera.com>
Date: 2015-10-19T18:14:32Z
shell clean up: +variable braces for consistency
----
> clean up shell scripts
> ----------------------
>
> Key: NIFI-1046
> URL: https://issues.apache.org/jira/browse/NIFI-1046
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Alex Moundalexis
> Priority: Minor
>
> The stock shell script that ships with NiFi has a few areas that diverge from best practices.
> Will propose some suggestions, please assign to me.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)