You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brian E. Fox" <br...@reply.infinity.nu> on 2009/02/20 01:11:27 UTC
RE: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
Why don't we just hookup checkstyle to maven?
-----Original Message-----
From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr]
Sent: Thursday, February 19, 2009 7:08 PM
To: dev@maven.apache.org
Subject: Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
Hi Shane,
There are a lot of coding style conventions problems in this commit:
- whitespace,
- implements/throws on a separate line,
> + private String parentGroupId = null, parentArtifactId = null,
> parentVersion = null, parentId = null, parentRelativePath;
each attribute should be declared on it own line
> -import java.io.File;
> -import java.io.IOException;
> +import java.io.*;
no wildcard imports
> + finally
> + {
> + if ( out != null )
> + {
> + out.close();
> + }
> + }
prefer IOUtil.close( out ) from plexus-utils, which has the necessary
try/catch to enforce safe code in any cases (I know this case is in-memory,
then not absolutely necessary)
Regards,
Hervé
Le jeudi 19 février 2009, sisbell@apache.org a écrit :
> Author: sisbell
> Date: Thu Feb 19 21:22:46 2009
> New Revision: 746002
>
> URL: http://svn.apache.org/viewvc?rev=746002&view=rev
> Log:
> Refactored out more uses of modello and moved classes from maven-project to
> maven-project-builder. Doing this so that maven-mercury will not have
> direct dependency on modello or maven model.
>
[SNAP]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
Posted by Stephen Connolly <st...@gmail.com>.
violations-Hudson-plugin is the way I'd go, it's written by peter
reilly over at ant.apache.org, and while he's a maven hater I can
usually bend his ear when the freestyle support is lacking
Sent from my [rhymes with myPod] ;-)
On 21 Feb 2009, at 12:13, Hervé BOUTEMY <he...@free.fr> wrote:
> oh yes, something like Violations Hudson plugin [1] for example
> would be a
> great enhancement, since this would be on a central machine and give
> history.
> Definitely helpful and should not be too complicated to add to
> existing CI
> instances.
> I'm not a Hudson expert, nor do I really know this plugin: I found
> it in
> Apache's Hudson instance then read the manual, I even not tried it. If
> anybody knows another plugin, no problem for me: for example, just
> found
> another one [2] that seems quite equivalent.
>
> There is still one feature missing: automatic blame when reports get
> worse on
> a commit. I didn't find anything like this.
>
> Regards,
>
> Hervé
>
>
> [1] http://wiki.hudson-ci.org/display/HUDSON/Violations
>
> [2] http://wiki.hudson-ci.org/display/HUDSON/Static+Code+Analysis+Plug-ins
>
> Le vendredi 20 février 2009, Brian E. Fox a écrit :
>> Ok, I mean either enable it all the time, or get some reports or CI
>> etc.
>>
>> -----Original Message-----
>> From: Dennis Lundberg [mailto:dennisl@apache.org]
>> Sent: Friday, February 20, 2009 11:26 AM
>> To: Maven Developers List
>> Subject: Re: svn commit: r746002 - in /maven/components/trunk:
>> maven-core/src/main/java/org/apache/maven/plugin/
>> maven-embedder/src/main/java/org/apache/maven/embedder/
>> maven-project-builder/
>> maven-project-builder/src/main/java/org/apache/maven/project/
>> builder/ ma
>>
>> We already have it in the Maven parent POM.
>>
>> When using the "reporting" profile you get a Checkstyle report for
>> the
>> current artifact.
>>
>> Brian E. Fox wrote:
>>> Why don't we just hookup checkstyle to maven?
>>>
>>> -----Original Message-----
>>> From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr]
>>> Sent: Thursday, February 19, 2009 7:08 PM
>>> To: dev@maven.apache.org
>>> Subject: Re: svn commit: r746002 - in /maven/components/trunk:
>>> maven-core/src/main/java/org/apache/maven/plugin/
>>> maven-embedder/src/main/java/org/apache/maven/embedder/
>>> maven-project-builder/
>>> maven-project-builder/src/main/java/org/apache/maven/project/
>>> builder/ ma
>>>
>>> Hi Shane,
>>>
>>> There are a lot of coding style conventions problems in this commit:
>>> - whitespace,
>>> - implements/throws on a separate line,
>>>
>>>> + private String parentGroupId = null, parentArtifactId = null,
>>>> parentVersion = null, parentId = null, parentRelativePath;
>>>
>>> each attribute should be declared on it own line
>>>
>>>> -import java.io.File;
>>>> -import java.io.IOException;
>>>> +import java.io.*;
>>>
>>> no wildcard imports
>>>
>>>> + finally
>>>> + {
>>>> + if ( out != null )
>>>> + {
>>>> + out.close();
>>>> + }
>>>> + }
>>>
>>> prefer IOUtil.close( out ) from plexus-utils, which has the
>>> necessary
>>> try/catch to enforce safe code in any cases (I know this case is
>>> in-memory, then not absolutely necessary)
>>>
>>>
>>> Regards,
>>>
>>> Hervé
>>>
>>> Le jeudi 19 février 2009, sisbell@apache.org a écrit :
>>>> Author: sisbell
>>>> Date: Thu Feb 19 21:22:46 2009
>>>> New Revision: 746002
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=746002&view=rev
>>>> Log:
>>>> Refactored out more uses of modello and moved classes from maven-
>>>> project
>>>> to maven-project-builder. Doing this so that maven-mercury will
>>>> not have
>>>> direct dependency on modello or maven model.
>>>
>>> [SNAP]
>>>
>>> ---
>>> ------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
Posted by Hervé BOUTEMY <he...@free.fr>.
oh yes, something like Violations Hudson plugin [1] for example would be a
great enhancement, since this would be on a central machine and give history.
Definitely helpful and should not be too complicated to add to existing CI
instances.
I'm not a Hudson expert, nor do I really know this plugin: I found it in
Apache's Hudson instance then read the manual, I even not tried it. If
anybody knows another plugin, no problem for me: for example, just found
another one [2] that seems quite equivalent.
There is still one feature missing: automatic blame when reports get worse on
a commit. I didn't find anything like this.
Regards,
Hervé
[1] http://wiki.hudson-ci.org/display/HUDSON/Violations
[2] http://wiki.hudson-ci.org/display/HUDSON/Static+Code+Analysis+Plug-ins
Le vendredi 20 février 2009, Brian E. Fox a écrit :
> Ok, I mean either enable it all the time, or get some reports or CI etc.
>
> -----Original Message-----
> From: Dennis Lundberg [mailto:dennisl@apache.org]
> Sent: Friday, February 20, 2009 11:26 AM
> To: Maven Developers List
> Subject: Re: svn commit: r746002 - in /maven/components/trunk:
> maven-core/src/main/java/org/apache/maven/plugin/
> maven-embedder/src/main/java/org/apache/maven/embedder/
> maven-project-builder/
> maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
>
> We already have it in the Maven parent POM.
>
> When using the "reporting" profile you get a Checkstyle report for the
> current artifact.
>
> Brian E. Fox wrote:
> > Why don't we just hookup checkstyle to maven?
> >
> > -----Original Message-----
> > From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr]
> > Sent: Thursday, February 19, 2009 7:08 PM
> > To: dev@maven.apache.org
> > Subject: Re: svn commit: r746002 - in /maven/components/trunk:
> > maven-core/src/main/java/org/apache/maven/plugin/
> > maven-embedder/src/main/java/org/apache/maven/embedder/
> > maven-project-builder/
> > maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
> >
> > Hi Shane,
> >
> > There are a lot of coding style conventions problems in this commit:
> > - whitespace,
> > - implements/throws on a separate line,
> >
> >> + private String parentGroupId = null, parentArtifactId = null,
> >> parentVersion = null, parentId = null, parentRelativePath;
> >
> > each attribute should be declared on it own line
> >
> >> -import java.io.File;
> >> -import java.io.IOException;
> >> +import java.io.*;
> >
> > no wildcard imports
> >
> >> + finally
> >> + {
> >> + if ( out != null )
> >> + {
> >> + out.close();
> >> + }
> >> + }
> >
> > prefer IOUtil.close( out ) from plexus-utils, which has the necessary
> > try/catch to enforce safe code in any cases (I know this case is
> > in-memory, then not absolutely necessary)
> >
> >
> > Regards,
> >
> > Hervé
> >
> > Le jeudi 19 février 2009, sisbell@apache.org a écrit :
> >> Author: sisbell
> >> Date: Thu Feb 19 21:22:46 2009
> >> New Revision: 746002
> >>
> >> URL: http://svn.apache.org/viewvc?rev=746002&view=rev
> >> Log:
> >> Refactored out more uses of modello and moved classes from maven-project
> >> to maven-project-builder. Doing this so that maven-mercury will not have
> >> direct dependency on modello or maven model.
> >
> > [SNAP]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
Ok, I mean either enable it all the time, or get some reports or CI etc.
-----Original Message-----
From: Dennis Lundberg [mailto:dennisl@apache.org]
Sent: Friday, February 20, 2009 11:26 AM
To: Maven Developers List
Subject: Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
We already have it in the Maven parent POM.
When using the "reporting" profile you get a Checkstyle report for the
current artifact.
Brian E. Fox wrote:
> Why don't we just hookup checkstyle to maven?
>
> -----Original Message-----
> From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr]
> Sent: Thursday, February 19, 2009 7:08 PM
> To: dev@maven.apache.org
> Subject: Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
>
> Hi Shane,
>
> There are a lot of coding style conventions problems in this commit:
> - whitespace,
> - implements/throws on a separate line,
>> + private String parentGroupId = null, parentArtifactId = null,
>> parentVersion = null, parentId = null, parentRelativePath;
> each attribute should be declared on it own line
>
>> -import java.io.File;
>> -import java.io.IOException;
>> +import java.io.*;
> no wildcard imports
>
>> + finally
>> + {
>> + if ( out != null )
>> + {
>> + out.close();
>> + }
>> + }
> prefer IOUtil.close( out ) from plexus-utils, which has the necessary
> try/catch to enforce safe code in any cases (I know this case is in-memory,
> then not absolutely necessary)
>
>
> Regards,
>
> Hervé
>
> Le jeudi 19 février 2009, sisbell@apache.org a écrit :
>> Author: sisbell
>> Date: Thu Feb 19 21:22:46 2009
>> New Revision: 746002
>>
>> URL: http://svn.apache.org/viewvc?rev=746002&view=rev
>> Log:
>> Refactored out more uses of modello and moved classes from maven-project to
>> maven-project-builder. Doing this so that maven-mercury will not have
>> direct dependency on modello or maven model.
>>
> [SNAP]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/
maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/
maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
Posted by Dennis Lundberg <de...@apache.org>.
We already have it in the Maven parent POM.
When using the "reporting" profile you get a Checkstyle report for the
current artifact.
Brian E. Fox wrote:
> Why don't we just hookup checkstyle to maven?
>
> -----Original Message-----
> From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr]
> Sent: Thursday, February 19, 2009 7:08 PM
> To: dev@maven.apache.org
> Subject: Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
>
> Hi Shane,
>
> There are a lot of coding style conventions problems in this commit:
> - whitespace,
> - implements/throws on a separate line,
>> + private String parentGroupId = null, parentArtifactId = null,
>> parentVersion = null, parentId = null, parentRelativePath;
> each attribute should be declared on it own line
>
>> -import java.io.File;
>> -import java.io.IOException;
>> +import java.io.*;
> no wildcard imports
>
>> + finally
>> + {
>> + if ( out != null )
>> + {
>> + out.close();
>> + }
>> + }
> prefer IOUtil.close( out ) from plexus-utils, which has the necessary
> try/catch to enforce safe code in any cases (I know this case is in-memory,
> then not absolutely necessary)
>
>
> Regards,
>
> Hervé
>
> Le jeudi 19 février 2009, sisbell@apache.org a écrit :
>> Author: sisbell
>> Date: Thu Feb 19 21:22:46 2009
>> New Revision: 746002
>>
>> URL: http://svn.apache.org/viewvc?rev=746002&view=rev
>> Log:
>> Refactored out more uses of modello and moved classes from maven-project to
>> maven-project-builder. Doing this so that maven-mercury will not have
>> direct dependency on modello or maven model.
>>
> [SNAP]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org