You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/01 16:06:16 UTC

[GitHub] [dolphinscheduler] kyoty edited a comment on pull request #5700: [Fix-5699][UI] Fix update user error in user information

kyoty edited a comment on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872367658


   @chengshiwen  @CalvinKirs @myangle1120 Sorry to bother you guys.
   + this PR is supposed to solve the problem introduced in #5627, sorry I'm not sure What problem was introduced in #5627? 
   I have tried to reproduce the screenshot menshoned in Issue#5699, but I can't reproduce it, it's a little strange. Can you tell me what problem was introduced @chengshiwen ,I want to know what had happend  so I can avoid similar mistakes in the future。
   
   + **In addition, I personally think that the current PR introduces a new problem: if we create a new user using admin, such as test, after successfully creating,  the current logged-in user displayed in the top right corner of the page will be updated to the current newly created user,** you can see my screenshot based on the latest code of dev:  
   
   1. try to add a new user named test, now the username of current user is admin.  
   
   ![image](https://user-images.githubusercontent.com/52202080/124154988-9733c980-dac8-11eb-8587-ad417b31f95e.png)  
   
   2. after the user has been created,  the username of current user changes from admin to test.  
   
   ![image](https://user-images.githubusercontent.com/52202080/124155152-c21e1d80-dac8-11eb-87b9-f228fe991e36.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org