You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by cesarhernandezgt <gi...@git.apache.org> on 2018/11/21 02:42:49 UTC
[GitHub] tomee pull request #210: WIP - Added basic structure for mp-rest-client exam...
GitHub user cesarhernandezgt opened a pull request:
https://github.com/apache/tomee/pull/210
WIP - Added basic structure for mp-rest-client example maven project
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cesarhernandezgt/tomee mp-rest-client-example
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #210
----
commit 5d492875d10401184137e44db97d20f48e2a1e0c
Author: CesarHernandezGt <cf...@...>
Date: 2018-11-20T22:29:10Z
Added basic structure for mp-rest-client example maven project
----
---
[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/210#discussion_r242252727
--- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/BookResource.java ---
@@ -0,0 +1,54 @@
+package org.superbiz.rest;
--- End diff --
You are missing the license header
---
[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project
Posted by cesarhernandezgt <gi...@git.apache.org>.
Github user cesarhernandezgt commented on the issue:
https://github.com/apache/tomee/pull/210
Since now the current master is using mp rest client 1.1, https://issues.apache.org/jira/browse/TOMEE-2298 is no longer blocking this PR.
This PR is ready for review.
---
[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project
Posted by cesarhernandezgt <gi...@git.apache.org>.
Github user cesarhernandezgt commented on the issue:
https://github.com/apache/tomee/pull/210
@brunobat , conflict is now fixed. thanks.
---
[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project
Posted by cesarhernandezgt <gi...@git.apache.org>.
Github user cesarhernandezgt commented on the issue:
https://github.com/apache/tomee/pull/210
@brunobat thank you for the catch.
I just pushed a new commit with the changes.
---
[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project
Posted by jeanouii <gi...@git.apache.org>.
Github user jeanouii commented on the issue:
https://github.com/apache/tomee/pull/210
Hey @cesarhernandezgt
What's up with this one?
Is it still work in progress or we can review and merge if ok?
---
[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/210#discussion_r242252818
--- Diff: examples/mp-rest-client/src/test/java/org/superbiz/rest/BookResourceClient.java ---
@@ -0,0 +1,40 @@
+package org.superbiz.rest;
--- End diff --
You are missing the license header
---
[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on the issue:
https://github.com/apache/tomee/pull/210
@cesarhernandezgt can you please fix the conflict? I'd like to review your PR.
---
[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tomee/pull/210
---
[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/210#discussion_r242252654
--- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/BookBean.java ---
@@ -0,0 +1,43 @@
+package org.superbiz.rest;
--- End diff --
You are missing the license header
---
[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project
Posted by cesarhernandezgt <gi...@git.apache.org>.
Github user cesarhernandezgt commented on the issue:
https://github.com/apache/tomee/pull/210
Hi, @jeanouii
This PR can't be merged now, we need a new cxf release to execute first: https://issues.apache.org/jira/browse/TOMEE-2298 and only after we can merge this PR.
I documented this dependency in the Jira ticket related with this pr https://issues.apache.org/jira/browse/TOMEE-2297
---
[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/210#discussion_r242252435
--- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/ApplicationConfig.java ---
@@ -0,0 +1,9 @@
+package org.superbiz.rest;
--- End diff --
You are missing the license header
---
[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/210#discussion_r242252858
--- Diff: examples/mp-rest-client/src/test/java/org/superbiz/rest/BookResourceTest.java ---
@@ -0,0 +1,60 @@
+package org.superbiz.rest;
--- End diff --
You are missing the license header
---
[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/210#discussion_r242252591
--- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/Book.java ---
@@ -0,0 +1,33 @@
+package org.superbiz.rest;
--- End diff --
You are missing the license header
---