You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/05/30 03:29:20 UTC

[GitHub] [hbase] q977734161 commented on a change in pull request #263: [HBASE-22476] FSDataInputStream is not closed.

q977734161 commented on a change in pull request #263: [HBASE-22476] FSDataInputStream is not closed.
URL: https://github.com/apache/hbase/pull/263#discussion_r288845648
 
 

 ##########
 File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java
 ##########
 @@ -438,6 +438,7 @@ public BackupManifest(FileSystem fs, Path backupPath) throws BackupException {
           long len = subFile.getLen();
           byte[] pbBytes = new byte[(int) len];
           in.readFully(pbBytes);
+          in.close();
 
 Review comment:
   Oh,yes, using the try-with-resources grammar is better. Thanks for reviewing the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services