You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/08/18 10:13:26 UTC

[GitHub] [incubator-dolphinscheduler] QiAnXinCodeSafe opened a new issue #3545: Unused Field

QiAnXinCodeSafe opened a new issue #3545:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3545


   https://github.com/apache/incubator-dolphinscheduler/blob/00e0003aed207adc33d1c4068977b172fa21d3f0/dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/utils/PropertyUtils.java#L44
   
   https://github.com/apache/incubator-dolphinscheduler/blob/00e0003aed207adc33d1c4068977b172fa21d3f0/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/PropertyUtils.java#L42
   
   These fields are never used.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong closed issue #3545: Unused Field

Posted by GitBox <gi...@apache.org>.
dailidong closed issue #3545:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3545


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #3545: Unused Field

Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #3545:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3545#issuecomment-675901196


   it used by itself,you can see it call `init` method
       private static final PropertyUtils propertyUtils = new PropertyUtils();
   
       private PropertyUtils(){
           init();
       }
   
       /**
        * init
        */
       private void init(){
           String[] propertyFiles = new String[]{Constants.DATASOURCE_PROPERTIES};
           for (String fileName : propertyFiles) {
               InputStream fis = null;
               try {
                   fis = PropertyUtils.class.getResourceAsStream(fileName);
                   properties.load(fis);
   
               } catch (IOException e) {
                   logger.error(e.getMessage(), e);
                   if (fis != null) {
                       IOUtils.closeQuietly(fis);
                   }
                   System.exit(1);
               } finally {
                   IOUtils.closeQuietly(fis);
               }
           }
       }


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org