[jira] [Commented] (VCL-999) Rework UnixLab.pm

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609478#comment-15609478 ] 

ASF subversion and git services commented on VCL-999:
-----------------------------------------------------

Commit 1766727 from arkurth@apache.org in branch 'vcl/trunk'
[ https://svn.apache.org/r1766727 ]

VCL-999
Rewrote much of UnixLab.pm. Added initialize subroutine which sets ssh_port and ssh_user keys in the OS object. These are used by OS.pm::execute and is_ssh_responding so that the correct port and username are used.

Replaced OS.pm::get_current_image_info with get_current_imagerevision_id. The old subroutine accepted various text strings to specify which piece of data to retrieve. This isn't very elegant. Separate subs should be written for each if necessary. All of the callers of get_current_image_info really only needed the imagerevision ID.

Updated OS.pm::is_ssh_responding to not check both port 22 and 24. It now checks if $self->{ssh_port} is set. If not, defaults only to 22.

Added OS.pm::wait_for_port_open and wait_for_port_closed. Similar functionality had existed in UnixLab.pm but was messy and didn't use the code_loop_timeout sub for the looping countdown.

Other
Added double quotes to the message string in Linux.pm::notify_user_console. It wasn't working if the message contained a newline.

> Rework UnixLab.pm
> -----------------
>
>                 Key: VCL-999
>                 URL: https://issues.apache.org/jira/browse/VCL-999
>             Project: VCL
>          Issue Type: Improvement
>          Components: vcld (backend)
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>             Fix For: 2.5
>
>
> The {{UnixLab.pm}} module contains a lot of outdated, sloppy code and needs to be reworked. It's currently functional but generates several warning messages are generated in vcld.log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)