You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/24 23:47:49 UTC

[jira] [Commented] (FLUME-989) Factor Flume Avro RPC interfaces out into separate Client SDK

    [ https://issues.apache.org/jira/browse/FLUME-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216031#comment-13216031 ] 

jiraposter@reviews.apache.org commented on FLUME-989:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4047/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Seeking early feedback on some additional APIs to make integrating with Flume 1.x easier.

Added the following APIs:
 - AvroClient: Friendly Java interface around the Avro API
 - AvroClientBuilder: Builder class to allow easy extension of AvroClient capabilities in the future (i.e. SSL)
 - DefaultAvroClient: Implementation of the AvroClient interface

Created this stuff in a flume-ng-sdk Maven submodule and moved the Event interface to that submodule. flume-ng-core depends on flume-ng-sdk.

I also modified AvroSink to use the AvroClient API instead of the bare AvroSourceProtocol API directly.


This addresses bug FLUME-989.
    https://issues.apache.org/jira/browse/FLUME-989


Diffs
-----

  flume-ng-core/pom.xml d753fa1 
  flume-ng-core/src/main/avro/flume.avdl 40da3ef 
  flume-ng-core/src/main/java/org/apache/flume/Event.java a017705 
  flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 5440631 
  flume-ng-sdk/pom.xml PRE-CREATION 
  flume-ng-sdk/src/main/avro/flume.avdl PRE-CREATION 
  flume-ng-sdk/src/main/java/org/apache/flume/Event.java PRE-CREATION 
  flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClient.java PRE-CREATION 
  flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClientBuilder.java PRE-CREATION 
  flume-ng-sdk/src/main/java/org/apache/flume/api/client/DefaultAvroClient.java PRE-CREATION 
  pom.xml d785762 

Diff: https://reviews.apache.org/r/4047/diff


Testing
-------


Thanks,

Mike


                
> Factor Flume Avro RPC interfaces out into separate Client SDK
> -------------------------------------------------------------
>
>                 Key: FLUME-989
>                 URL: https://issues.apache.org/jira/browse/FLUME-989
>             Project: Flume
>          Issue Type: Sub-task
>    Affects Versions: v1.0.0
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: v1.1.0
>
>
> Factor out the network RPC APIs so that there is a concise API boundary between user and developer APIs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira