[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4795: [KYUUBI #3420][UI] Kyuubi Server Proxy Engine UI

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4795:
URL: https://github.com/apache/kyuubi/pull/4795#discussion_r1218096592


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/ApiRootResource.scala:
##########
@@ -82,4 +82,13 @@ private[server] object ApiRootResource {
     handler.addServlet(holder, "/*")
     handler
   }
+
+  def getEngineUIProxyHandler(fe: KyuubiRestFrontendService): ServletContextHandler = {
+    val proxyServlet = new EngineUIProxyServlet()
+    val holder = new ServletHolder(proxyServlet)
+    val proxyHandler = new ServletContextHandler(ServletContextHandler.NO_SESSIONS);
+    proxyHandler.setContextPath(s"/${EngineUIProxyServlet.ENGINE_UI_PROXY_PATH}");

Review Comment:
   ```suggestion
       proxyHandler.setContextPath("/engine-ui");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org