You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/11 08:21:43 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
dongjoon-hyun opened a new pull request, #39022:
URL: https://github.com/apache/spark/pull/39022
### What changes were proposed in this pull request?
This PR aims to add `IPv4 and IPv6` section to K8s document.
### Why are the changes needed?
To document IPv6-only environment more explicitly.
### Does this PR introduce _any_ user-facing change?
No. This is a documentation PR.
### How was this patch tested?
Manually review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #39022:
URL: https://github.com/apache/spark/pull/39022#discussion_r1045283961
##########
docs/running-on-kubernetes.md:
##########
@@ -1418,15 +1438,17 @@ See the [configuration page](configuration.html) for information on Spark config
<td><code>spark.kubernetes.driver.service.ipFamilyPolicy</code></td>
<td><code>SingleStack</code></td>
<td>
- K8s IP Family Policy for Driver Service.
+ K8s IP Family Policy for Driver Service. Valid values are
+ <code>SingleStack</code>, <code>PreferDualStack</code>, and <code>RequireDualStack</code>.
</td>
<td>3.4.0</td>
</tr>
<tr>
<td><code>spark.kubernetes.driver.service.ipFamilies</code></td>
<td><code>IPv4</code></td>
<td>
- A list of IP families for K8s Driver Service.
+ A list of IP families for K8s Driver Service. Valid values are
+ <code>IPv4</code> and <code>IPv6</code>.
Review Comment:
Is `IPv4,IPv6` also valid value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #39022:
URL: https://github.com/apache/spark/pull/39022#discussion_r1045284167
##########
docs/running-on-kubernetes.md:
##########
@@ -1418,15 +1438,17 @@ See the [configuration page](configuration.html) for information on Spark config
<td><code>spark.kubernetes.driver.service.ipFamilyPolicy</code></td>
<td><code>SingleStack</code></td>
<td>
- K8s IP Family Policy for Driver Service.
+ K8s IP Family Policy for Driver Service. Valid values are
+ <code>SingleStack</code>, <code>PreferDualStack</code>, and <code>RequireDualStack</code>.
</td>
<td>3.4.0</td>
</tr>
<tr>
<td><code>spark.kubernetes.driver.service.ipFamilies</code></td>
<td><code>IPv4</code></td>
<td>
- A list of IP families for K8s Driver Service.
+ A list of IP families for K8s Driver Service. Valid values are
+ <code>IPv4</code> and <code>IPv6</code>.
Review Comment:
Oh, this is a list config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39022:
URL: https://github.com/apache/spark/pull/39022#discussion_r1045296465
##########
docs/running-on-kubernetes.md:
##########
@@ -1418,15 +1438,17 @@ See the [configuration page](configuration.html) for information on Spark config
<td><code>spark.kubernetes.driver.service.ipFamilyPolicy</code></td>
<td><code>SingleStack</code></td>
<td>
- K8s IP Family Policy for Driver Service.
+ K8s IP Family Policy for Driver Service. Valid values are
+ <code>SingleStack</code>, <code>PreferDualStack</code>, and <code>RequireDualStack</code>.
</td>
<td>3.4.0</td>
</tr>
<tr>
<td><code>spark.kubernetes.driver.service.ipFamilies</code></td>
<td><code>IPv4</code></td>
<td>
- A list of IP families for K8s Driver Service.
+ A list of IP families for K8s Driver Service. Valid values are
+ <code>IPv4</code> and <code>IPv6</code>.
Review Comment:
Yes~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
URL: https://github.com/apache/spark/pull/39022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39022:
URL: https://github.com/apache/spark/pull/39022#issuecomment-1345656755
Merged to master for Apache Spark 3.4. Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39022: [SPARK-41479][K8S][DOCS] Add `IPv4 and IPv6` section to K8s document
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39022:
URL: https://github.com/apache/spark/pull/39022#issuecomment-1345630114
cc @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org