[GitHub] mik-laj commented on a change in pull request #4483: [AIRFLOW-3673] Add official dockerfile

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #4483: [AIRFLOW-3673] Add official dockerfile
URL: https://github.com/apache/airflow/pull/4483#discussion_r247283083
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -0,0 +1,25 @@
+FROM python:3.6-slim
+COPY setup.* /opt/airflow/
+COPY airflow /opt/airflow/airflow
+
+ARG AIRFLOW_HOME=/usr/local/airflow
+ARG AIRFLOW_DEPS="all"
+ARG PYTHON_DEPS=""
+ARG buildDeps="freetds-dev libkrb5-dev libsasl2-dev libssl-dev libffi-dev libpq-dev git"
+ARG APT_DEPS="$buildDeps libsasl2-dev freetds-bin build-essential default-libmysqlclient-dev apt-utils curl rsync netcat locales"
+
+RUN set -x \
+    && export SLUGIFY_USES_TEXT_UNIDECODE=yes \
+    && apt update \
+    && if [ -n "${APT_DEPS}" ]; then apt install -y $APT_DEPS; fi \
+    && if [ -n "${PYTHON_DEPS}" ]; then pip install ${PYTHON_DEPS}; fi \
 
 Review comment:
   I suggest disable a cache for pip. 
   `pip install  --no-cache-dir `
   It does not apply to an isolated container environment and only increases the image.
   
   Other options: Remove cache at the end. Probably it will be ~/.cache/pip.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services