You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/26 15:03:07 UTC

[GitHub] [doris] starocean999 opened a new pull request, #11229: [fix] need materialize condition conlumn in if function

starocean999 opened a new pull request, #11229:
URL: https://github.com/apache/doris/pull/11229

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   if( condition, then, else ) the condition may be a const column. Before evaluate this function, condition column need to be materialized first.
   
   ## Checklist(Required)
   
   1. Type of your changes:
       - [ ] Improvement
       - [*] Fix
       - [ ] Feature-WIP
       - [ ] Feature
       - [ ] Doc
       - [ ] Refator
       - [ ] Others: 
   2. Does it affect the original behavior: 
       - [ ] Yes
       - [ *] No
       - [ ] I don't know
   3. Has unit tests been added:
       - [ ] Yes
       - [*] No
       - [ ] No Need
   4. Has document been added or modified:
       - [ ] Yes
       - [*] No
       - [ ] No Need
   5. Does it need to update dependencies:
       - [ ] Yes
       - [*] No
   6. Are there any changes that cannot be rolled back:
       - [ ] Yes
       - [*] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] kpfly commented on pull request #11229: [fix] need materialize condition conlumn in if function

Posted by GitBox <gi...@apache.org>.
kpfly commented on PR #11229:
URL: https://github.com/apache/doris/pull/11229#issuecomment-1195608182

   need fixed in version 1.1.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #11229: [fix] need materialize condition conlumn in if function

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11229:
URL: https://github.com/apache/doris/pull/11229#issuecomment-1195806921

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] stalary commented on pull request #11229: [fix] need materialize condition conlumn in if function

Posted by GitBox <gi...@apache.org>.
stalary commented on PR #11229:
URL: https://github.com/apache/doris/pull/11229#issuecomment-1196162970

   Need rebase to fix fe ut.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #11229: [fix] need materialize condition conlumn in if function

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11229:
URL: https://github.com/apache/doris/pull/11229


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org