[GitHub] [ozone] errose28 commented on pull request #3395: HDDS-6720. Pass OMMetadataManager to Request Validators in Upgrade Framework.

[GitBox <gi...@apache.org>]

errose28 commented on PR #3395:
URL: https://github.com/apache/ozone/pull/3395#issuecomment-1121522398

   Yes, ValidationContext is a sort of "parameter object" for the validators to get the info they need, so the info to get bucket layout should be added to that object. However, I do not think we should expose the whole metadata manager here, as it could easily be misused for anything other than a simple read request. I think it may be better to have the ValidationContext be constructed with a MetadataManager, but instead of exposing it as a getter, only expose a method like `ValidationContext#getBucketLayout(bucket)`, which uses the metadata manager internally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org