[GitHub] [spark] wypoon edited a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

[GitBox <gi...@apache.org>]

wypoon edited a comment on pull request #28848:
URL: https://github.com/apache/spark/pull/28848#issuecomment-648293945


   @tgravescs as you point out, it is ok to call `mapOutputTracker.removeOutputsOnHost` or `mapOutputTracker.removeOutputsOnExecutor` multiple times with the same host/execId. However, there is a lock that gets used.
   For this reason, to avoid calling removeOutputs multiple times, @attilapiros suggested using `fileLostEpoch` to track if the removeOutputs has already been called. Is there a better name for it you wish to suggest?
   Or do you still think that it is fine to call `mapOutputTracker.removeOutputsOnHost` or `mapOutputTracker.removeOutputsOnExecutor` multiple times?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org