You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/21 11:34:36 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #7149: arch: armv7-a: Remove the code for CONFIG_ARCH_PGPOOL_MAPPING=n

masayuki2009 commented on code in PR #7149:
URL: https://github.com/apache/incubator-nuttx/pull/7149#discussion_r976394218


##########
arch/arm/src/armv7-a/pgalloc.h:
##########
@@ -228,9 +197,7 @@ uintptr_t arm_physpgaddr(uintptr_t vaddr);
  *
  ****************************************************************************/
 
-#ifdef CONFIG_ARCH_PGPOOL_MAPPING

Review Comment:
   >should we select ARCH_PGPOOL_MAPPING for cortex-a in Kconfig automatically?
   
   @xiaoxiang781216 
   I think it's a good idea but should be done in a separate PR, because RISC-V has the same implementation.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org