You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/17 16:00:04 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1006: Update C++ standard to 17
PragmaTwice opened a new pull request, #1006:
URL: https://github.com/apache/incubator-kvrocks/pull/1006
check #970 for details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on pull request #1006: Update C++ standard to 17
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on PR #1006:
URL: https://github.com/apache/incubator-kvrocks/pull/1006#issuecomment-1281118950
I compiled successfully on Macos! Thank you very much for your contribution.❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1006: Update C++ standard to 17
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1006:
URL: https://github.com/apache/incubator-kvrocks/pull/1006#issuecomment-1281766368
Thanks all. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1006: Update C++ standard to 17
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #1006:
URL: https://github.com/apache/incubator-kvrocks/pull/1006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] xiaobiaozhao commented on pull request #1006: Update C++ standard to 17
Posted by GitBox <gi...@apache.org>.
xiaobiaozhao commented on PR #1006:
URL: https://github.com/apache/incubator-kvrocks/pull/1006#issuecomment-1281722609
Can I upgrade rocksdb to 7.x at the same time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] caipengbo commented on pull request #1006: Update C++ standard to 17
Posted by GitBox <gi...@apache.org>.
caipengbo commented on PR #1006:
URL: https://github.com/apache/incubator-kvrocks/pull/1006#issuecomment-1281747944
> Can I upgrade rocksdb to 7.x at the same time?
@xiaobiaozhao I think we can wait and see because `rocksdb7.x` is a lot different than `rocksdb6.x`. I'm not sure what services currently use `rocksdb7.x` for production (maybe we can ask in the rocksdb issue), and there's no immediate requirement for kvrocks to use the new `rocksdb7.x` features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org