You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ruleqa@spamassassin.apache.org by John Hardin <jh...@impsec.org> on 2012/12/12 19:16:55 UTC
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
On Wed, 12 Dec 2012, bugzilla-daemon@issues.apache.org wrote:
> Bug 6872, fix breakage introduced by my previous change - DNS replies
> with no answers would wait till their timeout
Ouch.
Yeah, that would explain the masscheck behavior. Anybody want to fire off
a test and see if this fixed the long runtimes?
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhardin@impsec.org FALaholic #11174 pgpk -a jhardin@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
The social contract exists so that everyone doesn't have to squat
in the dust holding a spear to protect his woman and his meat all
day every day. It does not exist so that the government can take
your spear, your meat, and your woman because it knows better what
to do with them. -- Dagny @ Ace of Spades
-----------------------------------------------------------------------
3 days until Bill of Rights day
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by John Hardin <jh...@impsec.org>.
On Wed, 12 Dec 2012, Mark Martinec wrote:
>> Please wait a little before testing, let me make sure everything is
>> alright.
>
> Ok, go now... (another commit)
Looks like that did it.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhardin@impsec.org FALaholic #11174 pgpk -a jhardin@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
The fetters imposed on liberty at home have ever been forged out
of the weapons provided for defense against real, pretended, or
imaginary dangers from abroad. -- James Madison, 1799
-----------------------------------------------------------------------
3 days until Bill of Rights day
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 12/12/2012 1:42 PM, Mark Martinec wrote:
>> Please wait a little before testing, let me make sure everything is
>> alright.
> Ok, go now... (another commit)
>
> Mark
Hmm, I thought masscheck had a mechanism for which version of the code
so that all masscheckers use the same code. Or is that something I
thought would be a good idea...
Regads,
KAM
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Mark Martinec <Ma...@ijs.si>.
> Please wait a little before testing, let me make sure everything is
> alright.
Ok, go now... (another commit)
Mark
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Axb <ax...@gmail.com>.
On 12/12/2012 09:39 PM, Axb wrote:
>> Great job, folks!
ACK! works great when run correctly <blush>
I'm seeing LOTS of "scantime=1.2" which is perfect!
Thanks Marc for the fast fix!
Axb
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Axb <ax...@gmail.com>.
On 12/12/2012 07:48 PM, Marc Andre Selig wrote:
> On Wed, Dec 12, 2012 at 07:38:27PM +0100, Marc Andre Selig wrote:
>
>> Here's the histogram of scan times so far:
>
> And here's the histogram of the first few messages with svn revision 1420907:
>
> mas@falun:~$ cat ~sacheck/masscheckwork/spamassassin-trunk/masses/*.log | perl -ne '/scantime=([0-9]+),/ && $h[$1]++; END{foreach $i (1..20) {printf "%2d: %d\n", $i, $h[$i]}}'
> 1: 72
> 2: 16
> 3: 1
> 4: 4
> 5: 31
> 6: 22
> 7: 9
> 8: 1
> 9: 6
> 10: 3
> 11: 0
> 12: 0
> 13: 0
> 14: 0
> 15: 0
> 16: 0
> 17: 0
> 18: 0
> 19: 0
> 20: 0
>
> Great job, folks!
>
I must be doing something wrong... still seein 15 sec scan times
back to the drawing board
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by John Hardin <jh...@impsec.org>.
On Wed, 12 Dec 2012, Marc Andre Selig wrote:
> And here's the histogram of the first few messages with svn revision 1420907:
>
> mas@falun:~$ cat ~sacheck/masscheckwork/spamassassin-trunk/masses/*.log | perl -ne '/scantime=([0-9]+),/ && $h[$1]++; END{foreach $i (1..20) {printf "%2d: %d\n", $i, $h[$i]}}'
> 1: 72
> 2: 16
> 3: 1
> 4: 4
> 5: 31
> 6: 22
> 7: 9
> 8: 1
> 9: 6
> 10: 3
> 11: 0
> 12: 0
> 13: 0
> 14: 0
> 15: 0
> 16: 0
> 17: 0
> 18: 0
> 19: 0
> 20: 0
>
> Great job, folks!
>
> Regards
> Marc
>
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhardin@impsec.org FALaholic #11174 pgpk -a jhardin@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
The social contract exists so that everyone doesn't have to squat
in the dust holding a spear to protect his woman and his meat all
day every day. It does not exist so that the government can take
your spear, your meat, and your woman because it knows better what
to do with them. -- Dagny @ Ace of Spades
-----------------------------------------------------------------------
3 days until Bill of Rights day
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Marc Andre Selig <a2...@sedacon.com>.
On Wed, Dec 12, 2012 at 07:38:27PM +0100, Marc Andre Selig wrote:
> Here's the histogram of scan times so far:
And here's the histogram of the first few messages with svn revision 1420907:
mas@falun:~$ cat ~sacheck/masscheckwork/spamassassin-trunk/masses/*.log | perl -ne '/scantime=([0-9]+),/ && $h[$1]++; END{foreach $i (1..20) {printf "%2d: %d\n", $i, $h[$i]}}'
1: 72
2: 16
3: 1
4: 4
5: 31
6: 22
7: 9
8: 1
9: 6
10: 3
11: 0
12: 0
13: 0
14: 0
15: 0
16: 0
17: 0
18: 0
19: 0
20: 0
Great job, folks!
Regards
Marc
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Marc Andre Selig <a2...@sedacon.com>.
On Wed, Dec 12, 2012 at 07:28:00PM +0100, Axb wrote:
> Still not good:
[...]
> 15 sec - still way too long
> can anybody reproduce?
Yup. I aborted after a few minutes because it appeared too slow, but
did not post because you had already volunteered.
Here's the histogram of scan times so far:
mas@falun:~$ cat ~sacheck/masscheckwork/weekly_mass_check/masses/*.log | perl -ne '/scantime=([0-9]+),/ && $h[$1]++; END{foreach $i (1..20) {printf "%2d: %d\n", $i, $h[$i]}}'
1: 0
2: 0
3: 0
4: 0
5: 0
6: 0
7: 0
8: 0
9: 0
10: 0
11: 1
12: 5
13: 9
14: 20
15: 24
16: 8
17: 1
18: 1
19: 1
20: 0
Regards
Marc
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Marc Andre Selig <a2...@sedacon.com>.
On Wed, Dec 12, 2012 at 10:37:41AM -0800, John Hardin wrote:
> Just checking: that does involve "svn up" and a make?
On my part, just a re-run of auto-mass-check.sh, which is supposed to
rsync "tagged_builds/weekly_mass_check". If nothing has been tagged yet,
please disregard my previous message. ;)
Regards
Marc
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by John Hardin <jh...@impsec.org>.
On Wed, 12 Dec 2012, Axb wrote:
> On 12/12/2012 07:18 PM, Axb wrote:
>> On 12/12/2012 07:16 PM, John Hardin wrote:
>> > On Wed, 12 Dec 2012, bugzilla-daemon@issues.apache.org wrote:
>> >
>> > > Bug 6872, fix breakage introduced by my previous change - DNS replies
>> > > with no answers would wait till their timeout
>> >
>> > Ouch.
>> >
>> > Yeah, that would explain the masscheck behavior. Anybody want to fire
>> > off a test and see if this fixed the long runtimes?
>> >
>>
>> Will do asap - left my test config in place last night...
>
> Still not good:
>
> 15 sec - still way too long
> can anybody reproduce?
Just checking: that does involve "svn up" and a make?
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhardin@impsec.org FALaholic #11174 pgpk -a jhardin@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
The social contract exists so that everyone doesn't have to squat
in the dust holding a spear to protect his woman and his meat all
day every day. It does not exist so that the government can take
your spear, your meat, and your woman because it knows better what
to do with them. -- Dagny @ Ace of Spades
-----------------------------------------------------------------------
3 days until Bill of Rights day
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Axb <ax...@gmail.com>.
On 12/12/2012 07:18 PM, Axb wrote:
> On 12/12/2012 07:16 PM, John Hardin wrote:
>> On Wed, 12 Dec 2012, bugzilla-daemon@issues.apache.org wrote:
>>
>>> Bug 6872, fix breakage introduced by my previous change - DNS replies
>>> with no answers would wait till their timeout
>>
>> Ouch.
>>
>> Yeah, that would explain the masscheck behavior. Anybody want to fire
>> off a test and see if this fixed the long runtimes?
>>
>
> Will do asap - left my test config in place last night...
Still not good:
Y 6 /home/foo.woas/Maildir/cur//1355297773.28901_2.inet4:2,
AXB_XMAILER_MIMEOLE_OL_4379D,HTML_MESSAGE,KB_RATWARE_MSGID,PYZOR_CHECK,T_BIG_HEADERS_3K,T_FSL_HELO_NON_FQDN_2,T_HELO_MISC_IP,T_KHOP_BIG_TO_CC,T_LONG_HEADER_LINE_80,T_MSGID_NOFQDN2,UNPARSEABLE_RELAY,__ANY_OUTLOOK_MUA,__ANY_TEXT_ATTACH,__ANY_TEXT_ATTACH_DOC,__AXB_MO_OL_03F7E,__AXB_MO_OL_1CC6A,__AXB_MO_OL_37CCA,__AXB_MO_OL_4379D,__AXB_MO_OL_5BD7E,__AXB_MO_OL_6B767,__AXB_MO_OL_8B970,__AXB_MO_OL_AE569,__AXB_MO_OL_C9F34,__AXB_MO_OL_EF682,__AXB_XM_OL_285BC,__AXB_XM_OL_4379D,__BOUNCE_RPATH_NULL,__CT,__CTYPE_HAS_BOUNDARY,__CTYPE_MULTIPART_ALT,__CTYPE_MULTIPART_ANY,__DOS_RCVD_WED,__DOS_RELAYED_EXT,__FH_HAS_XMSMAIL,__FH_HAS_XPRIORITY,__FROM_ENCODED_B64,__FROM_FULL_NAME,__FROM_NEEDS_MIME,__HAS_CC,__HAS_DATE,__HAS_FROM,__HAS_MESSAGE_ID,__HAS_MIMEOLE,__HAS_MSGID,__HAS_MSMAIL_PRI,__HAS_RCVD,__HAS_SUBJECT,__HAS_TO,__HAS_XMAIL,__HAS_X_MAILER,__HAVE_BOUNCE_RELAYS,__HELO_MISC_IP,__HIGHBITS,__KB_MSGID_OUTLOOK_888,__LAST_EXTERNAL_RELAY_NO_AUTH,__LAST_UNTRUSTED_RELAY_NO_AUTH,__MANY_RECIPS,__MIMEOLE_MS,__M
I
ME_HTML,__MIME_QP,__MIME_VERSION,__MISSING_REF,__MISSING_REPLY,__MISSING_THREAD,__MSGID_DOLLARS_MAYBE,__MSGID_DOLLARS_OK,__MSGID_OK_HEX,__MSGID_RANDY,__NONEMPTY_BODY,__NO_INR_YES_REF,__OE_MSGID_2,__OE_MUA,__RCVD_IN_ZEN,__RCVD_VIA_APNIC_E,__RCVD_VIA_RIPE,__RCVD_VIA_RIPE_E,__SANE_MSGID,__SUBJECT_ENCODED_B64,__SUBJECT_NEEDS_MIME,__SUBJ_NOT_SHORT,__TAG_EXISTS_BODY,__TAG_EXISTS_HEAD,__TAG_EXISTS_HTML,__TAG_EXISTS_META,__TAG_EXISTS_STYLE,__TOCC_EXISTS,__TVD_BODY,__TVD_MIME_ATT_TP,__UNPARSEABLE_RELAY_COUNT,__XM_MSOE6,__XM_MS_IN_GENERAL,__XM_OUTLOOK_EXPRESS,__XPRIO
time=1355297773,scantime=15,format=f,reuse=no,set=1
15 sec - still way too long
can anybody reproduce?
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Axb <ax...@gmail.com>.
On 12/12/2012 07:16 PM, John Hardin wrote:
> On Wed, 12 Dec 2012, bugzilla-daemon@issues.apache.org wrote:
>
>> Bug 6872, fix breakage introduced by my previous change - DNS replies
>> with no answers would wait till their timeout
>
> Ouch.
>
> Yeah, that would explain the masscheck behavior. Anybody want to fire
> off a test and see if this fixed the long runtimes?
>
Will do asap - left my test config in place last night...
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by da...@chaosreigns.com.
On 12/12, John Hardin wrote:
> Yeah, that would explain the masscheck behavior. Anybody want to
> fire off a test and see if this fixed the long runtimes?
Nice, thanks. It seems like we should make some attempt at monitoring for
drastic changes in masscheck run time. Like, I don't know, keep a log of
how long it takes each day, and maybe email an error to the person running
it if it runs a lot longer than usual.
--
"The whole aim of practical politics is to keep the populace alarmed --
and hence clamorous to be led to safety -- by menacing it with an endless
series of hobgoblins, all of them imaginary." - H. L. Mencken
http://www.ChaosReigns.com
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Axb <ax...@gmail.com>.
On 12/12/2012 07:30 PM, Mark Martinec wrote:
>>> Bug 6872, fix breakage introduced by my previous change - DNS replies
>>> with no answers would wait till their timeout
>>
>> Ouch.
>>
>> Yeah, that would explain the masscheck behavior. Anybody want to fire off
>> a test and see if this fixed the long runtimes?
>
> Please wait a little before testing, let me make sure everything is alright.
ooops - ok - just ran a test and it was still taking 15 sec.
shoot me a direct mail when you need a test run.
Axb
Re: [Bug 6872] Net::DNS 0.69 breaks sa-update
Posted by Mark Martinec <Ma...@ijs.si>.
> > Bug 6872, fix breakage introduced by my previous change - DNS replies
> > with no answers would wait till their timeout
>
> Ouch.
>
> Yeah, that would explain the masscheck behavior. Anybody want to fire off
> a test and see if this fixed the long runtimes?
Please wait a little before testing, let me make sure everything is alright.
Mark