You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by an...@apache.org on 2007/12/06 05:48:04 UTC
svn commit: r601609 -
/cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/binding/RepeaterJXPathBinding.java
Author: antonio
Date: Wed Dec 5 20:48:03 2007
New Revision: 601609
URL: http://svn.apache.org/viewvc?rev=601609&view=rev
Log:
Small improvement: ArrayLists have a predefined size.
Modified:
cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/binding/RepeaterJXPathBinding.java
Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/binding/RepeaterJXPathBinding.java
URL: http://svn.apache.org/viewvc/cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/binding/RepeaterJXPathBinding.java?rev=601609&r1=601608&r2=601609&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/binding/RepeaterJXPathBinding.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/binding/RepeaterJXPathBinding.java Wed Dec 5 20:48:03 2007
@@ -332,34 +332,33 @@
* @return List the identity of the row context
*/
private List getIdentity(JXPathContext rowContext) {
- if (this.identityBinding == null) {
- return Collections.EMPTY_LIST;
- }
-
- List identity = new ArrayList();
-
- JXPathBindingBase[] childBindings = this.identityBinding.getChildBindings();
- if (childBindings != null) {
- int size = childBindings.length;
- for (int i = 0; i < size; i++) {
- ValueJXPathBinding vBinding = (ValueJXPathBinding)childBindings[i];
- Object value = rowContext.getValue(vBinding.getXPath());
- if (value != null && vBinding.getConvertor() != null) {
- if (value instanceof String) {
- ConversionResult conversionResult = vBinding.getConvertor().convertFromString(
- (String)value, vBinding.getConvertorLocale(), null);
- if (conversionResult.isSuccessful())
- value = conversionResult.getResult();
- else
- value = null;
- } else {
- if (getLogger().isWarnEnabled()) {
- getLogger().warn("Convertor ignored on backend-value " +
- "which isn't of type String.");
+ List identity = Collections.EMPTY_LIST;
+ if (this.identityBinding != null) {
+ JXPathBindingBase[] childBindings = this.identityBinding.getChildBindings();
+ if (childBindings != null) {
+ int size = childBindings.length;
+ identity = new ArrayList(size);
+ for (int i = 0; i < size; i++) {
+ ValueJXPathBinding vBinding = (ValueJXPathBinding)childBindings[i];
+ Object value = rowContext.getValue(vBinding.getXPath());
+ if (value != null && vBinding.getConvertor() != null) {
+ if (value instanceof String) {
+ ConversionResult conversionResult = vBinding.getConvertor().convertFromString(
+ (String)value, vBinding.getConvertorLocale(), null);
+ if (conversionResult.isSuccessful()) {
+ value = conversionResult.getResult();
+ } else {
+ value = null;
+ }
+ } else {
+ if (getLogger().isWarnEnabled()) {
+ getLogger().warn("Convertor ignored on backend-value " +
+ "which isn't of type String.");
+ }
}
}
+ identity.add(value);
}
- identity.add(value);
}
}
return identity;
@@ -373,20 +372,18 @@
*/
private List getIdentity(Repeater.RepeaterRow row) {
// quit if we don't have an identity binding
- if (this.identityBinding == null) {
- return Collections.EMPTY_LIST;
- }
-
- List identity = new ArrayList();
-
- JXPathBindingBase[] childBindings = this.identityBinding.getChildBindings();
- if (childBindings != null) {
- int size = childBindings.length;
- for (int i = 0; i < size; i++) {
- String fieldId = ((ValueJXPathBinding) childBindings[i]).getFieldId();
- Widget widget = row.lookupWidget(fieldId);
- Object value = widget.getValue();
- identity.add(value);
+ List identity = Collections.EMPTY_LIST;
+ if (this.identityBinding != null) {
+ JXPathBindingBase[] childBindings = this.identityBinding.getChildBindings();
+ if (childBindings != null) {
+ int size = childBindings.length;
+ identity = new ArrayList(size);
+ for (int i = 0; i < size; i++) {
+ String fieldId = ((ValueJXPathBinding) childBindings[i]).getFieldId();
+ Widget widget = row.lookupWidget(fieldId);
+ Object value = widget.getValue();
+ identity.add(value);
+ }
}
}
return identity;