You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Chris Goffinet (JIRA)" <ji...@apache.org> on 2009/09/30 06:48:32 UTC
[jira] Created: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
nodeprobe setcompactionthreshold <Max> does not allow zero
----------------------------------------------------------
Key: CASSANDRA-465
URL: https://issues.apache.org/jira/browse/CASSANDRA-465
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.5
Reporter: Chris Goffinet
Assignee: Chris Goffinet
Priority: Minor
Fix For: 0.5
We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760934#action_12760934 ]
Jonathan Ellis commented on CASSANDRA-465:
------------------------------------------
Let's be a little more rigorous here.
We should require that min <= max.
min == max == 0 should disable compaction.
otherwise, min should be >= 2.
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763472#action_12763472 ]
Hudson commented on CASSANDRA-465:
----------------------------------
Integrated in Cassandra #221 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/221/])
Added the ability to set maxthreshold to zero in nodeprobe, and added a special case to CF.doCompaction to not run compaction when its disabled. patch by goffinet; reviewed by jbellis for
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Allow-maxthreshold-to-be-greater-than-zero-v2.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v3.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v4.patch, 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762686#action_12762686 ]
Jonathan Ellis commented on CASSANDRA-465:
------------------------------------------
maxthreshold default should be a constant in CompactionManager (that CM also defaults to of course)
currently max=0 disables compaction sort of by accident (from the sublist call in CFS.doCompaction), which generates a Warning log message. we should add a special case to doCompaction that doesn't call doFileCompaction at all in that case.
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Allow-maxthreshold-to-be-greater-than-zero-v2.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v3.patch, 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763277#action_12763277 ]
Jonathan Ellis commented on CASSANDRA-465:
------------------------------------------
imo the info line you added should be debug level for consistency.
other than that +1, go ahead and commit w/o an extra patch cycle
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Allow-maxthreshold-to-be-greater-than-zero-v2.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v3.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v4.patch, 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-465:
-------------------------------------
Attachment: 0001-Allow-maxthreshold-to-be-greater-than-zero-v3.patch
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Allow-maxthreshold-to-be-greater-than-zero-v2.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v3.patch, 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-465:
-------------------------------------
Attachment: 0001-Allow-maxthreshold-to-be-greater-than-zero-v4.patch
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Allow-maxthreshold-to-be-greater-than-zero-v2.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v3.patch, 0001-Allow-maxthreshold-to-be-greater-than-zero-v4.patch, 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-465:
-------------------------------------
Attachment: 0001-Allow-maxthreshold-to-be-greater-than-zero-v2.patch
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Allow-maxthreshold-to-be-greater-than-zero-v2.patch, 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-465) nodeprobe setcompactionthreshold
does not allow zero
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-465:
-------------------------------------
Attachment: 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
> nodeprobe setcompactionthreshold <Max> does not allow zero
> ----------------------------------------------------------
>
> Key: CASSANDRA-465
> URL: https://issues.apache.org/jira/browse/CASSANDRA-465
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-465.-Allow-maxthreshold-to-be-set-to-zero.patch
>
>
> We should allow setting maxthreshold to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.