You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2024/05/03 20:01:48 UTC
[PR] Send EOS event when QUIC connection becomes draining state [trafficserver]
maskit opened a new pull request, #11317:
URL: https://github.com/apache/trafficserver/pull/11317
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Send EOS event when QUIC connection becomes draining state [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #11317:
URL: https://github.com/apache/trafficserver/pull/11317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Send EOS event when QUIC connection becomes draining state [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #11317:
URL: https://github.com/apache/trafficserver/pull/11317#discussion_r1589681936
##########
src/iocore/net/QUICNetVConnection.cc:
##########
@@ -502,10 +511,8 @@ QUICNetVConnection::is_handshake_completed() const
void
QUICNetVConnection::net_read_io(NetHandler *nh, EThread *lthread)
{
- if (quiche_conn_is_readable(this->_quiche_con)) {
- SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
- this->handleEvent(QUIC_EVENT_PACKET_READ_READY, nullptr);
- }
+ SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
+ this->handleEvent(QUIC_EVENT_PACKET_READ_READY, nullptr);
Review Comment:
Checking `quiche_conn_is_readable` was wrong because the function checks whether there are readable *streams*. There may be something need to be processed on the connection level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Send EOS event when QUIC connection becomes draining state [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #11317:
URL: https://github.com/apache/trafficserver/pull/11317#discussion_r1589756634
##########
src/iocore/net/QUICNetVConnection.cc:
##########
@@ -180,6 +180,10 @@ QUICNetVConnection::state_handshake(int event, Event *data)
break;
}
+ if (this->closed != 1 && (quiche_conn_is_closed(this->_quiche_con) || quiche_conn_is_draining(this->_quiche_con))) {
Review Comment:
Ah, got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Send EOS event when QUIC connection becomes draining state [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #11317:
URL: https://github.com/apache/trafficserver/pull/11317#discussion_r1589750989
##########
src/iocore/net/QUICNetVConnection.cc:
##########
@@ -180,6 +180,10 @@ QUICNetVConnection::state_handshake(int event, Event *data)
break;
}
+ if (this->closed != 1 && (quiche_conn_is_closed(this->_quiche_con) || quiche_conn_is_draining(this->_quiche_con))) {
Review Comment:
I wish it were that simple. There is a place that sets it to -1 in UnixNetVConnection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Send EOS event when QUIC connection becomes draining state [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11317:
URL: https://github.com/apache/trafficserver/pull/11317#issuecomment-2225815418
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Send EOS event when QUIC connection becomes draining state [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #11317:
URL: https://github.com/apache/trafficserver/pull/11317#discussion_r1589709538
##########
src/iocore/net/QUICNetVConnection.cc:
##########
@@ -180,6 +180,10 @@ QUICNetVConnection::state_handshake(int event, Event *data)
break;
}
+ if (this->closed != 1 && (quiche_conn_is_closed(this->_quiche_con) || quiche_conn_is_draining(this->_quiche_con))) {
Review Comment:
Not directly related to this change, but should `closed` be a boolean? It seems like this would read better that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org