You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Runtian Liu <cu...@gmail.com> on 2025/01/17 00:32:54 UTC
[Committer/reviewer needed] Request for Review of Cassandra PRs
Hi all,
I hope you are doing well. I would like to request your review of two pull
requests I've submitted earlier:
1. *Inbound stream throttler* [CASSANDRA−
<https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
<https://issues.apache.org/jira/browse/CASSANDRA-11303>]
2. *Clear existing data when reset_bootstrap_progress is true* [CASSANDRA
− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
<https://issues.apache.org/jira/browse/CASSANDRA-20097>]
I'd really appreciate any thoughts you have on these changes. If you see
anything that needs tweaking, just let me know, and I'll jump right on it!
Thanks,
Runtian
Re: [Committer/reviewer needed] Request for Review of Cassandra PRs
Posted by Jaydeep Chovatia <ch...@gmail.com>.
One more ticket has been reviewed by one committer and needs another
committer to review.
- Local Hints are stepping on local mutations [CASSANDRA-19958
<https://issues.apache.org/jira/browse/CASSANDRA-19958>]
Jaydeep
On Mon, Apr 21, 2025 at 9:39 AM Runtian Liu <cu...@gmail.com> wrote:
> Hi,
> A gentle reminder on the following two changes:
>
> 1. *Inbound stream throttler* [CASSANDRA−
> <https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
> <https://issues.apache.org/jira/browse/CASSANDRA-11303>]
> 2. *Clear existing data when reset_bootstrap_progress is true* [
> CASSANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
> <https://issues.apache.org/jira/browse/CASSANDRA-20097>]
>
> I could use some help reviewing the inbound stream throttler patch. This
> change is particularly useful for deployments using vnodes, where node
> replacements often involve streaming from multiple sources.
> The second change has already received a +1. Could we please get another
> committer to review it?
>
> Thanks,
> Runtian
>
>
> On Thu, Jan 16, 2025 at 10:14 PM guo Maxwell <cc...@gmail.com> wrote:
>
>> I have added you as a reviewer of CASSANDRA-11303, you can do that for
>> CASSANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
>> <https://issues.apache.org/jira/browse/CASSANDRA-20097> by yourself.
>>
>> guo Maxwell <cc...@gmail.com> 于2025年1月17日周五 14:10写道：
>>
>>> Hi Wang,
>>> I think Runtian should change the ticket 's status ,submit a pr , then
>>> you can add yourself as a reviewer.
>>>
>>>
>>> Cheng Wang via dev <de...@cassandra.apache.org> 于2025年1月17日周五 14:05写道：
>>>
>>>> I can review the CASSANDRA-19248 first since it looks straight forward.
>>>> For CASSANDRA−11303 and CASSANDRA−
>>>> <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
>>>> <https://issues.apache.org/jira/browse/CASSANDRA-20097> I will try but
>>>> can't promise anything yet. How to add myself as a reviewer?
>>>>
>>>> On Thu, Jan 16, 2025 at 7:33 PM Paulo Motta <pa...@apache.org> wrote:
>>>>
>>>>> Thanks for this message Runtian.
>>>>>
>>>>> I realized I was previously assigned as reviewer for CASSANDRA−11303
>>>>> but I will not be able to review it at this time.
>>>>>
>>>>> There's also CASSANDRA-19248 that is waiting for review in case
>>>>> someone has cycles to review it.
>>>>>
>>>>> Reviewing community patches is a great way to learn more about the
>>>>> codebase and get involved with the project, even if you are not a
>>>>> committer. Any contributor can help by doing a first-pass review to triage
>>>>> the issue, run tests and check suggested items of the review checklist [1].
>>>>>
>>>>> Paulo
>>>>>
>>>>> [1] - https://cassandra.apache.org/_/development/how_to_review.html
>>>>>
>>>>> On Thu, Jan 16, 2025 at 7:34 PM Runtian Liu <cu...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> I hope you are doing well. I would like to request your review of two
>>>>>> pull requests I've submitted earlier:
>>>>>>
>>>>>> 1. *Inbound stream throttler* [CASSANDRA−
>>>>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
>>>>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>]
>>>>>> 2. *Clear existing data when reset_bootstrap_progress is true* [CA
>>>>>> SSANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>
>>>>>> 20097 <https://issues.apache.org/jira/browse/CASSANDRA-20097>]
>>>>>>
>>>>>> I'd really appreciate any thoughts you have on these changes. If you
>>>>>> see anything that needs tweaking, just let me know, and I'll jump right on
>>>>>> it!
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Runtian
>>>>>>
>>>>>
Re: [Committer/reviewer needed] Request for Review of Cassandra PRs
Posted by Runtian Liu <cu...@gmail.com>.
Hi,
A gentle reminder on the following two changes:
1. *Inbound stream throttler* [CASSANDRA−
<https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
<https://issues.apache.org/jira/browse/CASSANDRA-11303>]
2. *Clear existing data when reset_bootstrap_progress is true* [
CASSANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
<https://issues.apache.org/jira/browse/CASSANDRA-20097>]
I could use some help reviewing the inbound stream throttler patch. This
change is particularly useful for deployments using vnodes, where node
replacements often involve streaming from multiple sources.
The second change has already received a +1. Could we please get another
committer to review it?
Thanks,
Runtian
On Thu, Jan 16, 2025 at 10:14 PM guo Maxwell <cc...@gmail.com> wrote:
> I have added you as a reviewer of CASSANDRA-11303, you can do that for
> CASSANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
> <https://issues.apache.org/jira/browse/CASSANDRA-20097> by yourself.
>
> guo Maxwell <cc...@gmail.com> 于2025年1月17日周五 14:10写道：
>
>> Hi Wang,
>> I think Runtian should change the ticket 's status ,submit a pr , then
>> you can add yourself as a reviewer.
>>
>>
>> Cheng Wang via dev <de...@cassandra.apache.org> 于2025年1月17日周五 14:05写道：
>>
>>> I can review the CASSANDRA-19248 first since it looks straight forward.
>>> For CASSANDRA−11303 and CASSANDRA−
>>> <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
>>> <https://issues.apache.org/jira/browse/CASSANDRA-20097> I will try but
>>> can't promise anything yet. How to add myself as a reviewer?
>>>
>>> On Thu, Jan 16, 2025 at 7:33 PM Paulo Motta <pa...@apache.org> wrote:
>>>
>>>> Thanks for this message Runtian.
>>>>
>>>> I realized I was previously assigned as reviewer for CASSANDRA−11303
>>>> but I will not be able to review it at this time.
>>>>
>>>> There's also CASSANDRA-19248 that is waiting for review in case someone
>>>> has cycles to review it.
>>>>
>>>> Reviewing community patches is a great way to learn more about the
>>>> codebase and get involved with the project, even if you are not a
>>>> committer. Any contributor can help by doing a first-pass review to triage
>>>> the issue, run tests and check suggested items of the review checklist [1].
>>>>
>>>> Paulo
>>>>
>>>> [1] - https://cassandra.apache.org/_/development/how_to_review.html
>>>>
>>>> On Thu, Jan 16, 2025 at 7:34 PM Runtian Liu <cu...@gmail.com> wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> I hope you are doing well. I would like to request your review of two
>>>>> pull requests I've submitted earlier:
>>>>>
>>>>> 1. *Inbound stream throttler* [CASSANDRA−
>>>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
>>>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>]
>>>>> 2. *Clear existing data when reset_bootstrap_progress is true* [CA
>>>>> SSANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>
>>>>> 20097 <https://issues.apache.org/jira/browse/CASSANDRA-20097>]
>>>>>
>>>>> I'd really appreciate any thoughts you have on these changes. If you
>>>>> see anything that needs tweaking, just let me know, and I'll jump right on
>>>>> it!
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Runtian
>>>>>
>>>>
Re: [Committer/reviewer needed] Request for Review of Cassandra PRs
Posted by guo Maxwell <cc...@gmail.com>.
I have added you as a reviewer of CASSANDRA-11303, you can do that for
CASSANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
<https://issues.apache.org/jira/browse/CASSANDRA-20097> by yourself.
guo Maxwell <cc...@gmail.com> 于2025年1月17日周五 14:10写道：
> Hi Wang,
> I think Runtian should change the ticket 's status ,submit a pr , then you
> can add yourself as a reviewer.
>
>
> Cheng Wang via dev <de...@cassandra.apache.org> 于2025年1月17日周五 14:05写道：
>
>> I can review the CASSANDRA-19248 first since it looks straight forward.
>> For CASSANDRA−11303 and CASSANDRA−
>> <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
>> <https://issues.apache.org/jira/browse/CASSANDRA-20097> I will try but
>> can't promise anything yet. How to add myself as a reviewer?
>>
>> On Thu, Jan 16, 2025 at 7:33 PM Paulo Motta <pa...@apache.org> wrote:
>>
>>> Thanks for this message Runtian.
>>>
>>> I realized I was previously assigned as reviewer for CASSANDRA−11303 but
>>> I will not be able to review it at this time.
>>>
>>> There's also CASSANDRA-19248 that is waiting for review in case someone
>>> has cycles to review it.
>>>
>>> Reviewing community patches is a great way to learn more about the
>>> codebase and get involved with the project, even if you are not a
>>> committer. Any contributor can help by doing a first-pass review to triage
>>> the issue, run tests and check suggested items of the review checklist [1].
>>>
>>> Paulo
>>>
>>> [1] - https://cassandra.apache.org/_/development/how_to_review.html
>>>
>>> On Thu, Jan 16, 2025 at 7:34 PM Runtian Liu <cu...@gmail.com> wrote:
>>>
>>>> Hi all,
>>>>
>>>> I hope you are doing well. I would like to request your review of two
>>>> pull requests I've submitted earlier:
>>>>
>>>> 1. *Inbound stream throttler* [CASSANDRA−
>>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
>>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>]
>>>> 2. *Clear existing data when reset_bootstrap_progress is true* [CASS
>>>> ANDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
>>>> <https://issues.apache.org/jira/browse/CASSANDRA-20097>]
>>>>
>>>> I'd really appreciate any thoughts you have on these changes. If you
>>>> see anything that needs tweaking, just let me know, and I'll jump right on
>>>> it!
>>>>
>>>> Thanks,
>>>>
>>>> Runtian
>>>>
>>>
Re: [Committer/reviewer needed] Request for Review of Cassandra PRs
Posted by guo Maxwell <cc...@gmail.com>.
Hi Wang,
I think Runtian should change the ticket 's status ,submit a pr , then you
can add yourself as a reviewer.
Cheng Wang via dev <de...@cassandra.apache.org> 于2025年1月17日周五 14:05写道：
> I can review the CASSANDRA-19248 first since it looks straight forward.
> For CASSANDRA−11303 and CASSANDRA−
> <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
> <https://issues.apache.org/jira/browse/CASSANDRA-20097> I will try but
> can't promise anything yet. How to add myself as a reviewer?
>
> On Thu, Jan 16, 2025 at 7:33 PM Paulo Motta <pa...@apache.org> wrote:
>
>> Thanks for this message Runtian.
>>
>> I realized I was previously assigned as reviewer for CASSANDRA−11303 but
>> I will not be able to review it at this time.
>>
>> There's also CASSANDRA-19248 that is waiting for review in case someone
>> has cycles to review it.
>>
>> Reviewing community patches is a great way to learn more about the
>> codebase and get involved with the project, even if you are not a
>> committer. Any contributor can help by doing a first-pass review to triage
>> the issue, run tests and check suggested items of the review checklist [1].
>>
>> Paulo
>>
>> [1] - https://cassandra.apache.org/_/development/how_to_review.html
>>
>> On Thu, Jan 16, 2025 at 7:34 PM Runtian Liu <cu...@gmail.com> wrote:
>>
>>> Hi all,
>>>
>>> I hope you are doing well. I would like to request your review of two
>>> pull requests I've submitted earlier:
>>>
>>> 1. *Inbound stream throttler* [CASSANDRA−
>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
>>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>]
>>> 2. *Clear existing data when reset_bootstrap_progress is true* [CASSA
>>> NDRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
>>> <https://issues.apache.org/jira/browse/CASSANDRA-20097>]
>>>
>>> I'd really appreciate any thoughts you have on these changes. If you see
>>> anything that needs tweaking, just let me know, and I'll jump right on it!
>>>
>>> Thanks,
>>>
>>> Runtian
>>>
>>
Re: [Committer/reviewer needed] Request for Review of Cassandra PRs
Posted by Cheng Wang via dev <de...@cassandra.apache.org>.
I can review the CASSANDRA-19248 first since it looks straight forward.
For CASSANDRA−11303 and CASSANDRA−
<https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
<https://issues.apache.org/jira/browse/CASSANDRA-20097> I will try but
can't promise anything yet. How to add myself as a reviewer?
On Thu, Jan 16, 2025 at 7:33 PM Paulo Motta <pa...@apache.org> wrote:
> Thanks for this message Runtian.
>
> I realized I was previously assigned as reviewer for CASSANDRA−11303 but I
> will not be able to review it at this time.
>
> There's also CASSANDRA-19248 that is waiting for review in case someone
> has cycles to review it.
>
> Reviewing community patches is a great way to learn more about the
> codebase and get involved with the project, even if you are not a
> committer. Any contributor can help by doing a first-pass review to triage
> the issue, run tests and check suggested items of the review checklist [1].
>
> Paulo
>
> [1] - https://cassandra.apache.org/_/development/how_to_review.html
>
> On Thu, Jan 16, 2025 at 7:34 PM Runtian Liu <cu...@gmail.com> wrote:
>
>> Hi all,
>>
>> I hope you are doing well. I would like to request your review of two
>> pull requests I've submitted earlier:
>>
>> 1. *Inbound stream throttler* [CASSANDRA−
>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
>> <https://issues.apache.org/jira/browse/CASSANDRA-11303>]
>> 2. *Clear existing data when reset_bootstrap_progress is true* [CASSAN
>> DRA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
>> <https://issues.apache.org/jira/browse/CASSANDRA-20097>]
>>
>> I'd really appreciate any thoughts you have on these changes. If you see
>> anything that needs tweaking, just let me know, and I'll jump right on it!
>>
>> Thanks,
>>
>> Runtian
>>
>
Re: [Committer/reviewer needed] Request for Review of Cassandra PRs
Posted by Paulo Motta <pa...@apache.org>.
Thanks for this message Runtian.
I realized I was previously assigned as reviewer for CASSANDRA−11303 but I
will not be able to review it at this time.
There's also CASSANDRA-19248 that is waiting for review in case someone has
cycles to review it.
Reviewing community patches is a great way to learn more about the codebase
and get involved with the project, even if you are not a committer. Any
contributor can help by doing a first-pass review to triage the issue, run
tests and check suggested items of the review checklist [1].
Paulo
[1] - https://cassandra.apache.org/_/development/how_to_review.html
On Thu, Jan 16, 2025 at 7:34 PM Runtian Liu <cu...@gmail.com> wrote:
> Hi all,
>
> I hope you are doing well. I would like to request your review of two pull
> requests I've submitted earlier:
>
> 1. *Inbound stream throttler* [CASSANDRA−
> <https://issues.apache.org/jira/browse/CASSANDRA-11303>11303
> <https://issues.apache.org/jira/browse/CASSANDRA-11303>]
> 2. *Clear existing data when reset_bootstrap_progress is true* [CASSAND
> RA− <https://issues.apache.org/jira/browse/CASSANDRA-20097>20097
> <https://issues.apache.org/jira/browse/CASSANDRA-20097>]
>
> I'd really appreciate any thoughts you have on these changes. If you see
> anything that needs tweaking, just let me know, and I'll jump right on it!
>
> Thanks,
>
> Runtian
>