[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2775: ARTEMIS-2435 Configuration on device-block-size through CLI / broker.xml

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2775:  ARTEMIS-2435 Configuration on device-block-size through CLI / broker.xml
URL: https://github.com/apache/activemq-artemis/pull/2775#discussion_r308874238
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
 ##########
 @@ -44,7 +44,6 @@ public static final Double getDouble(final Element e,
          validator.validate(name, val);
          return val;
       } else {
-         validator.validate(name, def);
 
 Review comment:
   This is about validating the default value.
   
   If the user didn't make a selection, there's no need to validate the default value of a selection.
   
   
   I have been through specifically a case where device-block-size (a parameter that I will add) would be null if no selection, but in case there's a selection it must abide by the rules.
   
   The default value == null would be allowed. 
   
   There's no need to validate the default return value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services