[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4397: Gitlab remote api

["likyh (via GitHub)" <gi...@apache.org>]

likyh commented on code in PR #4397:
URL: https://github.com/apache/incubator-devlake/pull/4397#discussion_r1104114985


##########
backend/plugins/gitlab/api/remote.go:
##########
@@ -168,12 +182,18 @@ func RemoteScopes(input *plugin.ApiResourceInput) (*plugin.ApiResourceOutput, er
 		}
 	}
 
+	query, err = GetQueryFromPageData(pageData)
+	if err != nil {
+		return nil, err
+	}
+
 	// list projects part
 	if pageData.Tag == TypeProject {
 		if gid == "" {
 			res, err = apiClient.Get(fmt.Sprintf("users/%d/projects", apiClient.GetData(models.GitlabApiClientData_UserId)), query, nil)
 		} else {
-			res, err = apiClient.Get(fmt.Sprintf("/groups/%s/subgroups", gid), query, nil)
+			query.Set("with_shared", "false")
+			res, err = apiClient.Get(fmt.Sprintf("/groups/%s/projects", gid), query, nil)

Review Comment:
   subgroups -> projects?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org