You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2017/01/03 18:09:09 UTC

[GitHub] cordova-plugin-inappbrowser pull request #205: CB-9148 - (android) Add suppo...

Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94452072
  
    --- Diff: src/android/InAppBrowser.java ---
    @@ -722,7 +729,57 @@ public void onClick(View v) {
                     inAppWebView = new WebView(cordova.getActivity());
                     inAppWebView.setLayoutParams(new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));
                     inAppWebView.setId(Integer.valueOf(6));
    -                inAppWebView.setWebChromeClient(new InAppChromeClient(thatWebView));
    +                // File Chooser Implemented ChromeClient
    +                inAppWebView.setWebChromeClient(new InAppChromeClient(thatWebView) {
    +                    // For Android 5.0+
    +                    public boolean onShowFileChooser (WebView webView, ValueCallback<Uri[]> filePathCallback, WebChromeClient.FileChooserParams fileChooserParams)
    +                    {
    +                        Log.d(LOG_TAG, "File Chooser 5.0+");
    +                        // If callback exists, finish it.
    +                        if(mUploadCallbackLollipop != null) {
    +                            mUploadCallbackLollipop.onReceiveValue(null);
    +                        }
    +                        mUploadCallbackLollipop = filePathCallback;
    +
    +                        // Create File Chooser Intent
    +                        Intent content = new Intent(Intent.ACTION_GET_CONTENT);
    +                        content.addCategory(Intent.CATEGORY_OPENABLE);
    +                        content.setType("*/*");
    +
    +                        // [important] Register ActvityResultCallback on Cordova
    +                        cordova.setActivityResultCallback(InAppBrowser.this);
    +                        cordova.getActivity().startActivityForResult(content, FILECHOOSER_REQUESTCODE_LOLLIPOP);
    +                        return true;
    +                    }
    +
    +                    // For Android 4.1+
    +                    public void openFileChooser(ValueCallback<Uri> uploadMsg, String acceptType, String capture)
    +                    {
    +                        Log.d(LOG_TAG, "File Chooser 4.1+");
    +                        // Call file chooser for Android 3.0+
    +                        openFileChooser(uploadMsg, acceptType);
    +                    }
    +
    +                    // For Android 3.0+
    +                    public void openFileChooser(ValueCallback<Uri> uploadMsg, String acceptType)
    +                    {
    +                        Log.d(LOG_TAG, "File Chooser 3.0+");
    +                        mUploadCallback = uploadMsg;
    +                        Intent i = new Intent(Intent.ACTION_GET_CONTENT);
    +                        i.addCategory(Intent.CATEGORY_OPENABLE);
    +
    +                        cordova.setActivityResultCallback(InAppBrowser.this);
    +                        cordova.getActivity().startActivityForResult( Intent.createChooser(i, "File Chooser"), FILECHOOSER_REQUESTCODE);
    +                    }
    +
    +                    // For Android < 3.0
    +                    public void openFileChooser(ValueCallback<Uri> uploadMsg) {
    +                        Log.d(LOG_TAG, "File Chooser 3.0 <");
    +                        // Call file chooser for Android 3.0+
    +                        openFileChooser(uploadMsg, "");
    +                    }
    +
    --- End diff --
    
    Why does this need to be here? We do not support any versions of Android below Android 4.1, so this would never be called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org