[GitHub] [hadoop] saintstack commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

[GitBox <gi...@apache.org>]

saintstack commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-703789784


   If making a new PR, the '   <scope>compile</scope>' is redundant given its maven default?
   
   The license failure is:
   
   ```
   Lines that start with ????? in the ASF License  report indicate files that do not have an Apache license header:
    !????? /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2297/src/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/jobTokenPassword
   ```
   
   No harm fixing it as part of this patch... add the 'jobTokenPassword' from below in ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
   
   ```
          <plugin>
            <groupId>org.apache.rat</groupId>
            <artifactId>apache-rat-plugin</artifactId>
            <configuration>
              <excludes>
                <exclude>src/test/java/org/apache/hadoop/cli/data60bytes</exclude>
                <exclude>src/test/resources/job_1329348432655_0001-10.jhist</exclude>
                <exlude>**/jobTokenPassword</exclude>
              </excludes>
            </configuration>
          </plugin>
   ```
   Otherwise patch is looking good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org