[GitHub] [inlong] healchow commented on a diff in pull request #7118: [INLONG-7073][Sort] Support table level metrics for Apache Iceberg connector

[GitBox <gi...@apache.org>]

healchow commented on code in PR #7118:
URL: https://github.com/apache/inlong/pull/7118#discussion_r1060069843


##########
inlong-sort/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/DynamicSchemaHandleOperator.java:
##########
@@ -182,6 +229,11 @@ private void handleDirtyData(Object dirtyData, JsonNode rootNode, DirtyType dirt
                             .setIdentifier(dirtyOptions.getIdentifier());
                 }
                 dirtySink.invoke(builder.build());
+                if (metricData != null) {
+                    metricData.outputMetricsWithEstimate(

Review Comment:
   The `outputMetricsWithEstimate` method seems used unsuitable params.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org