You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by dl...@apache.org on 2004/11/20 10:30:35 UTC

svn commit: r105959 - jakarta/velocity/trunk/src/java/org/apache/velocity/runtime/directive

Author: dlr
Date: Sat Nov 20 01:30:34 2004
New Revision: 105959

Modified:
   jakarta/velocity/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java
Log:
* src/java/org/apache/velocity/runtime/directive/Macro.java
  processAndRegister(): Removed unnecessary local String variable,
  allowing reuse of its meaningful name, "macroBody", in place of one
  named "temp".


Modified: jakarta/velocity/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java
==============================================================================
--- jakarta/velocity/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java	(original)
+++ jakarta/velocity/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java	Sat Nov 20 01:30:34 2004
@@ -48,7 +48,7 @@
  *  macro.  It is used inline in the parser when processing a directive.
  *
  * @author <a href="mailto:geirm@optonline.net">Geir Magnusson Jr.</a>
- * @version $Id: Macro.java,v 1.18 2004/03/19 17:13:35 dlr Exp $
+ * @version $Id$
  */
 public class Macro extends Directive
 {
@@ -174,21 +174,19 @@
          *  make a big string out of our macro
          */
   
-        StringBuffer temp  = new StringBuffer();
+        StringBuffer macroBody = new StringBuffer();
 
         for (int i=0; i < macroArray.size(); i++)
         {
-            temp.append(macroArray.get(i));
+            macroBody.append(macroArray.get(i));
         }
 
-        String macroBody = temp.toString();
-   
         /*
          * now, try to add it.  The Factory controls permissions, 
          * so just give it a whack...
          */
 
-        boolean bRet = rs.addVelocimacro(argArray[0], macroBody,
+        boolean bRet = rs.addVelocimacro(argArray[0], macroBody.toString(),
                         argArray, sourceTemplate);
 
         return;

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org