You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/06/05 19:35:22 UTC
Review Request 22266: Removed deprecated 'offer_id' from LaunchTasksMessage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22266/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-1451
https://issues.apache.org/jira/browse/MESOS-1451
Repository: mesos-git
Description
-------
The scheduler driver has been using the new 'offer_ids' field since 0.18.0 so we should follow up and remove the deprecated 'offer_id' field. This simplifies the master logic and the driver logic.
Diffs
-----
src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1
src/master/master.cpp 91dc1fd85ed83913ab5c7542a96a9d71160b4f94
src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4
src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
Diff: https://reviews.apache.org/r/22266/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 22266: Removed deprecated 'offer_id' from
LaunchTasksMessage.
Posted by Ben Mahler <be...@gmail.com>.
> On June 5, 2014, 6:46 p.m., Niklas Nielsen wrote:
> > Looks good - thanks! Do we still want to maintain the overloaded launchTasks() in the scheduler APIs (Java, Python, ...)?
Great point, I think for now it makes sense to keep them given the lower-level API is in the works. I noticed the python documentation doesn't reflect the fact that a list can be passed in, I'll update this change accordingly.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22266/#review44836
-----------------------------------------------------------
On June 5, 2014, 5:35 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22266/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 5:35 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-1451
> https://issues.apache.org/jira/browse/MESOS-1451
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The scheduler driver has been using the new 'offer_ids' field since 0.18.0 so we should follow up and remove the deprecated 'offer_id' field. This simplifies the master logic and the driver logic.
>
>
> Diffs
> -----
>
> src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1
> src/master/master.cpp 91dc1fd85ed83913ab5c7542a96a9d71160b4f94
> src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4
> src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
>
> Diff: https://reviews.apache.org/r/22266/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 22266: Removed deprecated 'offer_id' from
LaunchTasksMessage.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22266/#review44836
-----------------------------------------------------------
Ship it!
Looks good - thanks! Do we still want to maintain the overloaded launchTasks() in the scheduler APIs (Java, Python, ...)?
- Niklas Nielsen
On June 5, 2014, 10:35 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22266/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 10:35 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-1451
> https://issues.apache.org/jira/browse/MESOS-1451
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The scheduler driver has been using the new 'offer_ids' field since 0.18.0 so we should follow up and remove the deprecated 'offer_id' field. This simplifies the master logic and the driver logic.
>
>
> Diffs
> -----
>
> src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1
> src/master/master.cpp 91dc1fd85ed83913ab5c7542a96a9d71160b4f94
> src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4
> src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
>
> Diff: https://reviews.apache.org/r/22266/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 22266: Removed deprecated 'offer_id' from
LaunchTasksMessage.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22266/
-----------------------------------------------------------
(Updated June 6, 2014, 10:27 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated the stale python documentation.
Bugs: MESOS-1451
https://issues.apache.org/jira/browse/MESOS-1451
Repository: mesos-git
Description
-------
The scheduler driver has been using the new 'offer_ids' field since 0.18.0 so we should follow up and remove the deprecated 'offer_id' field. This simplifies the master logic and the driver logic.
Diffs (updated)
-----
src/master/master.hpp e2448310aa714b5fae49b9bf4fc95859ae9d7ec3
src/master/master.cpp 89f426c14de365369b900864f1983b1f9260953f
src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4
src/python/src/mesos.py a2fc0e92a021f96214bfcfe9cf9703ed6290803b
src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
Diff: https://reviews.apache.org/r/22266/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 22266: Removed deprecated 'offer_id' from
LaunchTasksMessage.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22266/#review44948
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 5, 2014, 5:35 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22266/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 5:35 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-1451
> https://issues.apache.org/jira/browse/MESOS-1451
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The scheduler driver has been using the new 'offer_ids' field since 0.18.0 so we should follow up and remove the deprecated 'offer_id' field. This simplifies the master logic and the driver logic.
>
>
> Diffs
> -----
>
> src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1
> src/master/master.cpp 91dc1fd85ed83913ab5c7542a96a9d71160b4f94
> src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4
> src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
>
> Diff: https://reviews.apache.org/r/22266/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>