[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3076: [GOBBLIN-1230] add option to add spec executor configs to gaas job

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #3076:
URL: https://github.com/apache/incubator-gobblin/pull/3076#discussion_r469605369



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec, Config sysConfig) {
 
       Config config = jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig, additionalConfigsPrefix));
 
+      config = config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig, additionalConfigsPrefix));

Review comment:
       Will the prefix key be included in the config or will it be dropped? e.g. "specExecutor.a.b" and prefix is "a", will this return "a.b" or just "b"? 

##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
##########
@@ -153,6 +153,7 @@
   public static final String MAPPER_TASK_ATTEMPT_NUM_KEY = ConfigurationKeys.METRICS_CONFIGURATIONS_PREFIX + "reporting.mapper.task.attempt.num";
   public static final String REDUCER_TASK_NUM_KEY = ConfigurationKeys.METRICS_CONFIGURATIONS_PREFIX + "reporting.reducer.task.num";
   public static final String REDUCER_TASK_ATTEMPT_NUM_KEY = ConfigurationKeys.METRICS_CONFIGURATIONS_PREFIX + "reporting.reducer.task.attempt.num";
+  public static final String NUM_MAPPERS = "numMappers";

Review comment:
       Where is this being used?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org