You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2010/09/30 22:08:34 UTC
[jira] Created: (HBASE-3058) Fix REST tests on trunk
Fix REST tests on trunk
-----------------------
Key: HBASE-3058
URL: https://issues.apache.org/jira/browse/HBASE-3058
Project: HBase
Issue Type: Bug
Components: rest
Affects Versions: 0.90.0
Reporter: Jonathan Gray
Priority: Critical
Fix For: 0.90.0
Most of the REST tests do not pass on trunk. Most likely because configuration is being generated internally within REST classes rather than being passed in, so when tests override configs they are not getting picked up.
There was a similar issue already fixed with thrift and avro.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3058) Fix REST tests on trunk
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916644#action_12916644 ]
HBase Review Board commented on HBASE-3058:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/927/
-----------------------------------------------------------
Review request for hbase, stack and Andrew Purtell.
Summary
-------
This method adds Configuration as a parameter to almost all the rest classes. This is because they all extend a base class, ResourceBase, which just holds a reference to a single RESTServlet that gets instantiated as a singleton. It's this RESTServlet which needs to take a Configuration. Since ResourceBase is instantiated all over the place, everything needs Configuration.
This doesn't work though. Most of these classes get instantiated through REST/JAX automagic, so it's getting null Configuration.
Could use some help.
This addresses bug HBASE-3058.
http://issues.apache.org/jira/browse/HBASE-3058
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/rest/ExistsResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/Main.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/ResourceBase.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/ResultGenerator.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/RootResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/RowResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/ScannerInstanceResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterVersionResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java 1003206
trunk/src/main/java/org/apache/hadoop/hbase/rest/VersionResource.java 1003206
Diff: http://review.cloudera.org/r/927/diff
Testing
-------
REST tests failing now with NPE because everything gets null Configuration objects. Without patch they fail because they try to contact the wrong master.
Thanks,
Jonathan
> Fix REST tests on trunk
> -----------------------
>
> Key: HBASE-3058
> URL: https://issues.apache.org/jira/browse/HBASE-3058
> Project: HBase
> Issue Type: Bug
> Components: rest
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
>
> Most of the REST tests do not pass on trunk. Most likely because configuration is being generated internally within REST classes rather than being passed in, so when tests override configs they are not getting picked up.
> There was a similar issue already fixed with thrift and avro.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-3058) Fix REST tests on trunk
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-3058:
---------------------------------
Attachment: HBASE-3058-v3.patch
Simpler fix. REST tests passing.
> Fix REST tests on trunk
> -----------------------
>
> Key: HBASE-3058
> URL: https://issues.apache.org/jira/browse/HBASE-3058
> Project: HBase
> Issue Type: Bug
> Components: rest
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-3058-v3.patch
>
>
> Most of the REST tests do not pass on trunk. Most likely because configuration is being generated internally within REST classes rather than being passed in, so when tests override configs they are not getting picked up.
> There was a similar issue already fixed with thrift and avro.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-3058) Fix REST tests on trunk
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray resolved HBASE-3058.
----------------------------------
Hadoop Flags: [Reviewed]
Assignee: Jonathan Gray
Resolution: Fixed
Committed v3 patch. Thanks for help and review Andrew!
> Fix REST tests on trunk
> -----------------------
>
> Key: HBASE-3058
> URL: https://issues.apache.org/jira/browse/HBASE-3058
> Project: HBase
> Issue Type: Bug
> Components: rest
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-3058-v3.patch
>
>
> Most of the REST tests do not pass on trunk. Most likely because configuration is being generated internally within REST classes rather than being passed in, so when tests override configs they are not getting picked up.
> There was a similar issue already fixed with thrift and avro.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3058) Fix REST tests on trunk
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916673#action_12916673 ]
HBase Review Board commented on HBASE-3058:
-------------------------------------------
Message from: "Andrew Purtell" <ap...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/927/#review1369
-----------------------------------------------------------
Ship it!
- Andrew
> Fix REST tests on trunk
> -----------------------
>
> Key: HBASE-3058
> URL: https://issues.apache.org/jira/browse/HBASE-3058
> Project: HBase
> Issue Type: Bug
> Components: rest
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-3058-v3.patch
>
>
> Most of the REST tests do not pass on trunk. Most likely because configuration is being generated internally within REST classes rather than being passed in, so when tests override configs they are not getting picked up.
> There was a similar issue already fixed with thrift and avro.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3058) Fix REST tests on trunk
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916666#action_12916666 ]
HBase Review Board commented on HBASE-3058:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/927/
-----------------------------------------------------------
(Updated 2010-09-30 13:50:57.922028)
Review request for hbase, stack and Andrew Purtell.
Changes
-------
Much simpler patch. REST tests passing.
Summary
-------
This method adds Configuration as a parameter to almost all the rest classes. This is because they all extend a base class, ResourceBase, which just holds a reference to a single RESTServlet that gets instantiated as a singleton. It's this RESTServlet which needs to take a Configuration. Since ResourceBase is instantiated all over the place, everything needs Configuration.
This doesn't work though. Most of these classes get instantiated through REST/JAX automagic, so it's getting null Configuration.
Could use some help.
This addresses bug HBASE-3058.
http://issues.apache.org/jira/browse/HBASE-3058
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java 1003250
trunk/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTClusterTestBase.java 1003206
Diff: http://review.cloudera.org/r/927/diff
Testing
-------
REST tests failing now with NPE because everything gets null Configuration objects. Without patch they fail because they try to contact the wrong master.
Thanks,
Jonathan
> Fix REST tests on trunk
> -----------------------
>
> Key: HBASE-3058
> URL: https://issues.apache.org/jira/browse/HBASE-3058
> Project: HBase
> Issue Type: Bug
> Components: rest
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-3058-v3.patch
>
>
> Most of the REST tests do not pass on trunk. Most likely because configuration is being generated internally within REST classes rather than being passed in, so when tests override configs they are not getting picked up.
> There was a similar issue already fixed with thrift and avro.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.