[GitHub] [mynewt-core] brianwyld commented on a change in pull request #2130: Remove restriction in syscfg to define bitbang RX pin

[GitBox <gi...@apache.org>]

brianwyld commented on a change in pull request #2130: Remove restriction in syscfg to define bitbang RX pin
URL: https://github.com/apache/mynewt-core/pull/2130#discussion_r357223145
 
 

 ##########
 File path: hw/mcu/stm/stm32l1xx/src/ext/Drivers/STM32L1xx_HAL_Driver/Src/stm32l1xx_hal_spi.c
 ##########
 @@ -171,6 +171,7 @@ static HAL_StatusTypeDef SPI_WaitOnFlagUntilTimeout(struct __SPI_HandleTypeDef *
   * @{
   */
 
+#if 0 /* Fully defined in stm32l1xx_hal_spi_ex.c */
 
 Review comment:
   I went for the #if 0 as I don't actually understand why the 'proper' hal_spi_init() function is in the _ex file and not just in the base one.
   And in fact my change is now redundant (as you note) because someone else has copied the working HAL_SPI_Init() directly into the stm32_common area with the #if for the STM32L152 (although I don't see why that is 'better' as a solution than fixing it in the STM32L1xx driver source?) The STM32L152 is close enough to the STM32L151 that I can just #define the L152 one as well...
   I'll back out my change as its no longer required... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services