You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "och5351 (via GitHub)" <gi...@apache.org> on 2026/06/11 17:19:41 UTC
[PR] [FLINK-39914][runtime] Fix flaky TaskDeploymentDescriptorFactoryTest#testHybridVertexFinish caused by async TDD creation [flink]
och5351 opened a new pull request, #28398:
URL: https://github.com/apache/flink/pull/28398
## What is the purpose of the change
Execution.deploy() now creates TaskDeploymentDescriptor asynchronously, which means the IO executor thread calls jobMasterMainThreadExecutor.execute() to hand off the work.
The problem is that forMainThread() captures the calling thread at the time of its creation and asserts inside execute() that only that same thread can call it.
Since the IO executor thread calls execute() instead, the assertion fires and throws an AssertionError. This error then bubbles up through the CompletableFuture chain, flipping the producer vertex into FAILED state, which causes an IllegalStateException when the consumer vertex tries to read from it.
## Brief change log
Updated buildExecutionGraph() in TaskDeploymentDescriptorFactoryTest to replace forMainThread() with forSingleThreadExecutor() and add proper async handling to accommodate the asynchronous TaskDeploymentDescriptor creation in Execution.deploy().
## Verifying this change
<img width="2626" height="1902" alt="image" src="https://github.com/user-attachments/assets/78dbdeaa-f8f1-4a1f-b60a-a61c13c99553" />
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change the checkbox below to `[X]` followed by the name of the tool, and uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed. See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name and Version]
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39914][runtime] Fix flaky TaskDeploymentDescriptorFactoryTest#testHybridVertexFinish caused by async TDD creation [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #28398:
URL: https://github.com/apache/flink/pull/28398#issuecomment-4698692644
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39914][runtime] Fix flaky TaskDeploymentDescriptorFactoryTest#testHybridVertexFinish caused by async TDD creation [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28398:
URL: https://github.com/apache/flink/pull/28398#issuecomment-4683217106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5d84c1103842d869f211a92962d349bb72b4909f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5d84c1103842d869f211a92962d349bb72b4909f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d84c1103842d869f211a92962d349bb72b4909f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39914][runtime] Fix flaky TaskDeploymentDescriptorFactoryTest#testHybridVertexFinish caused by async TDD creation [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #28398:
URL: https://github.com/apache/flink/pull/28398#issuecomment-4700353772
Thanks @och5351 @lihaosky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39914][runtime] Fix flaky TaskDeploymentDescriptorFactoryTest#testHybridVertexFinish caused by async TDD creation [flink]
Posted by "lihaosky (via GitHub)" <gi...@apache.org>.
lihaosky merged PR #28398:
URL: https://github.com/apache/flink/pull/28398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39914][runtime] Fix flaky TaskDeploymentDescriptorFactoryTest#testHybridVertexFinish caused by async TDD creation [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #28398:
URL: https://github.com/apache/flink/pull/28398#issuecomment-4697750858
Hi, @och5351 The CI failed, Could you help take a look ? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39914][runtime] Fix flaky TaskDeploymentDescriptorFactoryTest#testHybridVertexFinish caused by async TDD creation [flink]
Posted by "och5351 (via GitHub)" <gi...@apache.org>.
och5351 commented on PR #28398:
URL: https://github.com/apache/flink/pull/28398#issuecomment-4698909602
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org