[GitHub] [incubator-superset] ktmud commented on a change in pull request #11428: fix: Explore popovers issues

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #11428:
URL: https://github.com/apache/incubator-superset/pull/11428#discussion_r512129773



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
##########
@@ -150,6 +150,45 @@ describe('Time range filter', () => {
   });
 });
 
+describe('AdhocFilter control', () => {

Review comment:
       `AdhocFilterControl` already has its own test file: https://github.com/apache/incubator-superset/blob/901a42b1df68423e176705740e0c589727bbafb8/superset-frontend/cypress-base/cypress/integration/explore/AdhocFilters.test.ts#L52
   
   The auto popup behavior was actually captured by the test, but disabled by this line: https://github.com/apache/incubator-superset/commit/901a42b1df68423e176705740e0c589727bbafb8#diff-3988fce84e5b2c937f6d320addc74db15b55519f5234b116657cc8c1b9db0f81R77
   
   You can just remove this line (and probably a comment saying how this will capture the case that adding a new filter will auto-open the popup).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org