[jira] [Resolved] (CALCITE-3004) RexOver is incorrectly pushed down in ProjectSetOpTransposeRule and ProjectCorrelateTransposeRule

["Haisheng Yuan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haisheng Yuan resolved CALCITE-3004.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.20.0

Fixed in commit https://github.com/apache/calcite/commit/f26d92f956c4f8b59bafbf7cfc7431f3d4d536f9, thanks for the PR, [~Chunwei Lei]!

> RexOver is incorrectly pushed down in ProjectSetOpTransposeRule and ProjectCorrelateTransposeRule
> -------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3004
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3004
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.19.0
>            Reporter: Hongze Zhang
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.20.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> *1. Test case for ProjectSetOpTransposeRule:*
> {code:sql}
> select count(sal) over () from (select * from emp e1 union all select * from emp e2)
> {code}
> Plan:
> {code:java}
> LogicalUnion(all=[true])
>   LogicalProject(EXPR$0=[COUNT($5) OVER (RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING)])
>     LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
>       LogicalTableScan(table=[[CATALOG, SALES, EMP]])
>   LogicalProject(EXPR$0=[COUNT($5) OVER (RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING)])
>     LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
>       LogicalTableScan(table=[[CATALOG, SALES, EMP]])
> {code}
> Should be:
> {code:java}
> LogicalProject(EXPR$0=[COUNT($5) OVER (RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING)])
>   LogicalUnion(all=[true])
>     LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
>       LogicalTableScan(table=[[CATALOG, SALES, EMP]])
>     LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
>       LogicalTableScan(table=[[CATALOG, SALES, EMP]]){code}
>  
> *2. Test case for ProjectCorrelateTransposeRule:*
> {code:sql}
> select t2.empno, sum(t1.deptno) over () from DEPT_NESTED as t1, unnest(t1.employees) as t2
> {code}
> *Plan: Will cause infinitely loop due to RexOver is pushed down*
> Should be:
>  
> {code:java}
> LogicalProject(EMPNO=[$2], EXPR$1=[SUM($0) OVER (RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING)])
>   LogicalCorrelate(correlation=[$cor1], joinType=[inner], requiredColumns=[{1}])
>     LogicalProject(DEPTNO=[$0], EMPLOYEES=[$3])
>       LogicalTableScan(table=[[CATALOG, SALES, DEPT_NESTED]])
>   LogicalProject(EMPNO=[$0])
>     Uncollect
>       LogicalProject(EMPLOYEES=[$cor1.EMPLOYEES])
>         LogicalValues(tuples=[[{ 0 }]]){code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)