[GitHub] busbey commented on a change in pull request #198: Added Accumulo and Hadoop compat checks

[GitBox <gi...@apache.org>]

busbey commented on a change in pull request #198: Added Accumulo and Hadoop compat checks
URL: https://github.com/apache/fluo-uno/pull/198#discussion_r219557345
 
 

 ##########
 File path: conf/uno.conf
 ##########
 @@ -91,6 +91,27 @@ if [[ -n "$FLUO_YARN_REPO" ]]; then
   export FLUO_YARN_TARBALL=fluo-yarn-$FLUO_YARN_VERSION-bin.tar.gz
 fi
 
+# Version compatability checks
+# ----------------------------
+# Apache built Accumuo 1.x only works with Hadoop 2.x.  Apache built Accumulo
+# 2.x only works with Hadoop 3.x.  However if building Accumulo, these
+# constraints may not apply.  The following sanity checks fail fast when
+# versions are incompatible.  If the checks cause a problem, comment them out
+# and consider submitting an issue or PR.
+#
+
+if [[ -z "$ACCUMULO_REPO" ]]; then
+  if [[ "${ACCUMULO_VERSION}" = 1.* && ! "${HADOOP_VERSION}" = 2.* ]]; then
 
 Review comment:
   I presume we're not trying to support versions of Accumulo old enough for it to matter that this is only true for 1.6+?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services