You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/02/25 18:41:12 UTC
Review Request 44020: adding unit tests for REST API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/
-----------------------------------------------------------
Review request for geode, Anthony Baker and Dan Smith.
Repository: geode
Description
-------
A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
Diff: https://reviews.apache.org/r/44020/diff/
Testing
-------
The new tests pass when run from gradle or eclipse
Thanks,
Bruce Schuchardt
Re: Review Request 44020: adding unit tests for REST API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On Feb. 25, 2016, 7:21 p.m., Dan Smith wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java, line 57
> > <https://reviews.apache.org/r/44020/diff/1/?file=1271099#file1271099line57>
> >
> > It looks like you're setting things up so that running a test in eclipse will find a war file built by the command line build? I think that's going to be confusing. People will modify the code in eclipse and expect the modifications to have an effect when the run the test.
I don't see another way to allow the tests to run in Eclipse. They deploy the WAR into a web server. Do you think I should just disable the ability to run them in Eclipse? That'll make it harder for the people developing new tests for REST.
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120739
-----------------------------------------------------------
On Feb. 25, 2016, 9:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 9:41 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
> geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
It looks like there is a way to create a Web project in Eclipse and a
plugin for Gradle to create them but I don't know enough about either to
work on it.
I've created a JIRA ticket to track the issue and reverted my changes to
AgentUtil.
All of the tests have been modified in setUp to fail quickly if they
can't find the WAR file.
Le 2/25/2016 3:20 PM, Dan Smith a écrit :
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
>
>
> On February 25th, 2016, 7:21 p.m. UTC, *Dan Smith* wrote:
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java
> <https://reviews.apache.org/r/44020/diff/1/?file=1271099#file1271099line57>
> (Diff revision 1)
>
> public class AgentUtil {
>
>
>
> 57
>
> // initial checks for unit-test locations
>
> It looks like you're setting things up so that running a test
> in eclipse will find a war file built by the command line
> build? I think that's going to be confusing. People will
> modify the code in eclipse and expect the modifications to
> have an effect when the run the test.
>
> On February 25th, 2016, 9:42 p.m. UTC, *Bruce Schuchardt* wrote:
>
> I don't see another way to allow the tests to run in Eclipse.
> They deploy the WAR into a web server. Do you think I should
> just disable the ability to run them in Eclipse? That'll make
> it harder for the people developing new tests for REST.
>
> Hmm. It's too bad we can't just test this stuff with the eclipse
> generated files. I guess it's better to at least be able to write the
> test in eclipse. Maybe we should have a convention of putting anything
> that relies on command line generated artifacts in a special place or
> some other way of making it clear that they are testing the command
> line build.
>
>
> - Dan
>
>
> On February 25th, 2016, 9:41 p.m. UTC, Bruce Schuchardt wrote:
>
> Review request for geode, Anthony Baker and Dan Smith.
> By Bruce Schuchardt.
>
> /Updated Feb. 25, 2016, 9:41 p.m./
>
> *Repository: * geode
>
>
> Description
>
> A number of unit tests were still sitting in the work queue to be
> moved to open-source including all of the REST API tests. This change
> set shows the build changes and AgentUtil changes needed to accomodate
> the new tests but does not show the new tests. The tests are being
> added to the geode-web-api project, and all of the support classes in
> geode-core's com.gemstone.gemfire.rest.internal.web.controllers
> package are being moved to that project.
>
>
> Testing
>
> The new tests pass when run from gradle or eclipse
>
>
> Diffs
>
> * geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java
> (0310658d2182f90bc8e2041cd0f6b0f0b53c6568)
> * geode-web-api/build.gradle (51848c2b750373cfcc1c5ba9f0b24417ac38745d)
> * gradle/dependency-versions.properties
> (611ee7a413d70d9c72b5ca0a5384b4dee7c26c60)
>
> View Diff <https://reviews.apache.org/r/44020/diff/>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Dan Smith <ds...@pivotal.io>.
> On Feb. 25, 2016, 7:21 p.m., Dan Smith wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java, line 57
> > <https://reviews.apache.org/r/44020/diff/1/?file=1271099#file1271099line57>
> >
> > It looks like you're setting things up so that running a test in eclipse will find a war file built by the command line build? I think that's going to be confusing. People will modify the code in eclipse and expect the modifications to have an effect when the run the test.
>
> Bruce Schuchardt wrote:
> I don't see another way to allow the tests to run in Eclipse. They deploy the WAR into a web server. Do you think I should just disable the ability to run them in Eclipse? That'll make it harder for the people developing new tests for REST.
Hmm. It's too bad we can't just test this stuff with the eclipse generated files. I guess it's better to at least be able to write the test in eclipse. Maybe we should have a convention of putting anything that relies on command line generated artifacts in a special place or some other way of making it clear that they are testing the command line build.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120739
-----------------------------------------------------------
On Feb. 25, 2016, 9:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 9:41 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
> geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120739
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java (line 57)
<https://reviews.apache.org/r/44020/#comment182209>
It looks like you're setting things up so that running a test in eclipse will find a war file built by the command line build? I think that's going to be confusing. People will modify the code in eclipse and expect the modifications to have an effect when the run the test.
geode-web-api/build.gradle (line 64)
<https://reviews.apache.org/r/44020/#comment182208>
This is an overcomplicated way to look up the task. These can just be:
distributedTest.dependsOn(war)
- Dan Smith
On Feb. 25, 2016, 5:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 5:41 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
> geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On Feb. 25, 2016, 10:02 p.m., Jinmei Liao wrote:
> > geode-web-api/build.gradle, line 64
> > <https://reviews.apache.org/r/44020/diff/2/?file=1271298#file1271298line64>
> >
> > maybe checkout what the geode-assembly module is doing. The AgentUtilJunitTest in that module is checking the same thing
> > distributedTest dependOnInstalledProduct
> > integrationTest dependOnInstalledProduct
> >
> > this would make sure that if you run either integration tests or distributed tests, the war files are generated.
Thanks Jinmei - I'll try that
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120783
-----------------------------------------------------------
On Feb. 25, 2016, 9:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 9:41 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
> geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120783
-----------------------------------------------------------
geode-web-api/build.gradle (line 64)
<https://reviews.apache.org/r/44020/#comment182272>
maybe checkout what the geode-assembly module is doing. The AgentUtilJunitTest in that module is checking the same thing
distributedTest dependOnInstalledProduct
integrationTest dependOnInstalledProduct
this would make sure that if you run either integration tests or distributed tests, the war files are generated.
- Jinmei Liao
On Feb. 25, 2016, 9:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 9:41 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
> geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/
-----------------------------------------------------------
(Updated Feb. 25, 2016, 11:45 p.m.)
Review request for geode, Anthony Baker and Dan Smith.
Changes
-------
Moving the tests to geode-assembly, which is already set up to have test depend on the installed product. The tests have been modified to fail fast if run under an IDE like Eclipse and a JIRA ticket has been created for this problem. Changes to AgentUtil have been reverted.
Repository: geode
Description
-------
A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
Diffs (updated)
-----
geode-assembly/build.gradle 2a46147c04061a709bc5ae7b2ff596a6083ec5a6
gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
Diff: https://reviews.apache.org/r/44020/diff/
Testing
-------
The new tests pass when run from gradle or eclipse
Thanks,
Bruce Schuchardt
Re: Review Request 44020: adding unit tests for REST API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/
-----------------------------------------------------------
(Updated Feb. 25, 2016, 9:41 p.m.)
Review request for geode, Anthony Baker and Dan Smith.
Changes
-------
simplified code adding dependencies and properties to tests
Repository: geode
Description
-------
A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
Diff: https://reviews.apache.org/r/44020/diff/
Testing
-------
The new tests pass when run from gradle or eclipse
Thanks,
Bruce Schuchardt
Re: Review Request 44020: adding unit tests for REST API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
That would be my preference. It seems like we ought to be able to
create more JUnit tests for REST and do away with the DUnit tests.
Le 2/25/2016 3:51 PM, Jens Deppe a écrit :
> Do the tests really warrant a full container being stood up? Could they be exercised using the Spring MVC mock test framework?
Re: Review Request 44020: adding unit tests for REST API
Posted by Jens Deppe <jd...@pivotal.io>.
> On Feb. 25, 2016, 8:45 p.m., Jens Deppe wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java, line 57
> > <https://reviews.apache.org/r/44020/diff/1/?file=1271099#file1271099line57>
> >
> > The code a little further down is supposed to provide the ability to discover the war file on the classpath. Please try and utilize that capability instead of adding build-specifics here.
>
> Bruce Schuchardt wrote:
> If I rely on the code lower down in the method it will not be executed if the environment happens to have a GEMFIRE_HOME env variable set. I have one of these set and it causes the tests to fail. Unit tests shouldn't be affected by environment variables - especially one that a geode developer might easily have set in their environment.
Do the tests really warrant a full container being stood up? Could they be exercised using the Spring MVC mock test framework?
- Jens
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120761
-----------------------------------------------------------
On Feb. 25, 2016, 11:45 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 11:45 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 2a46147c04061a709bc5ae7b2ff596a6083ec5a6
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On Feb. 25, 2016, 8:45 p.m., Jens Deppe wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java, line 57
> > <https://reviews.apache.org/r/44020/diff/1/?file=1271099#file1271099line57>
> >
> > The code a little further down is supposed to provide the ability to discover the war file on the classpath. Please try and utilize that capability instead of adding build-specifics here.
If I rely on the code lower down in the method it will not be executed if the environment happens to have a GEMFIRE_HOME env variable set. I have one of these set and it causes the tests to fail. Unit tests shouldn't be affected by environment variables - especially one that a geode developer might easily have set in their environment.
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120761
-----------------------------------------------------------
On Feb. 25, 2016, 5:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 5:41 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
> geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44020: adding unit tests for REST API
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120761
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java (line 57)
<https://reviews.apache.org/r/44020/#comment182249>
The code a little further down is supposed to provide the ability to discover the war file on the classpath. Please try and utilize that capability instead of adding build-specifics here.
- Jens Deppe
On Feb. 25, 2016, 5:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 5:41 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> A number of unit tests were still sitting in the work queue to be moved to open-source including all of the REST API tests. This change set shows the build changes and AgentUtil changes needed to accomodate the new tests but does not show the new tests. The tests are being added to the geode-web-api project, and all of the support classes in geode-core's com.gemstone.gemfire.rest.internal.web.controllers package are being moved to that project.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java 0310658d2182f90bc8e2041cd0f6b0f0b53c6568
> geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d
> gradle/dependency-versions.properties 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60
>
> Diff: https://reviews.apache.org/r/44020/diff/
>
>
> Testing
> -------
>
> The new tests pass when run from gradle or eclipse
>
>
> Thanks,
>
> Bruce Schuchardt
>
>