[jira] [Commented] (ZOOKEEPER-2056) Zookeeper 3.4.x and 3.5.0-alpha is not OSGi compliant

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387142#comment-14387142 ] 

Hadoop QA commented on ZOOKEEPER-2056:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12708191/ZOOKEEPER-2056.patch
  against trunk revision 1669825.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2596//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2596//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2596//console

This message is automatically generated.

> Zookeeper 3.4.x and 3.5.0-alpha is not OSGi compliant
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-2056
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2056
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: Keren Dong
>              Labels: easyfix
>         Attachments: ZOOKEEPER-2056.patch
>
>
> Similar to this issue https://issues.apache.org/jira/browse/ZOOKEEPER-1334, the MANIFEST.MF is still flawed. When using in OSGi, I got this exception:
> java.lang.NoClassDefFoundError: org/ietf/jgss/GSSException
>         at org.apache.zookeeper.ClientCnxn$SendThread.startConnect(ClientCnxn.java:1063)[168:org.apache.hadoop.zookeeper:3.5.01]
>         at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1114)[168:org.apache.hadoop.zookeeper:3.5.01]
> Caused by: java.lang.ClassNotFoundException: org.ietf.jgss.GSSException not found by org.apache.hadoop.zookeeper [168]
>         at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1532)[org.apache.felix.framework-4.2.1.jar:]
>         at org.apache.felix.framework.BundleWiringImpl.access$400(BundleWiringImpl.java:75)[org.apache.felix.framework-4.2.1.jar:]
>         at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1955)[org.apache.felix.framework-4.2.1.jar:]
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:356)[:1.7.0_15]
>         ... 2 more
> Looking at the bundle headers, it doesn't have the package org.ietf.jgss imported:
> Import-Package =
>         javax.management;resolution:=optional,
>         javax.security.auth.callback,
>         javax.security.auth.login,
>         javax.security.sasl,
>         org.slf4j;version="[1.6,2)",
>         org.jboss.netty.buffer;resolution:=optional;version="[3.2,4)",
>         org.jboss.netty.channel;resolution:=optional;version="[3.2,4)",
>         org.jboss.netty.channel.group;resolution:=optional;version="[3.2,4)",
>         org.jboss.netty.channel.socket.nio;resolution:=optional;version="[3.2,4)",
>         org.osgi.framework;resolution:=optional;version="[1.5,2)",
>         org.osgi.util.tracker;resolution:=optional;version="[1.4,2)"
> Export-Package =
>         org.apache.zookeeper;version=3.5.01,
>         org.apache.zookeeper.client;version=3.5.01,
>         org.apache.zookeeper.data;version=3.5.01,
>         org.apache.zookeeper.version;version=3.5.01,
>         org.apache.zookeeper.server;version=3.5.01,
>         org.apache.zookeeper.server.auth;version=3.5.01,
>         org.apache.zookeeper.server.persistence;version=3.5.01,
>         org.apache.zookeeper.server.quorum;version=3.5.01,
>         org.apache.zookeeper.common;version=3.5.01



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)