You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "tpalfy (via GitHub)" <gi...@apache.org> on 2025/08/13 15:04:55 UTC
[PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
tpalfy opened a new pull request, #10200:
URL: https://github.com/apache/nifi/pull/10200
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-14857](https://issues.apache.org/jira/browse/NIFI-14857)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #10200: NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method.
URL: https://github.com/apache/nifi/pull/10200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "tpalfy (via GitHub)" <gi...@apache.org>.
tpalfy commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3191564481
Updated the Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3191621445
@tpalfy
> Although I think overall it would only be to NiFi's benefit if we considered components extensible.
I infer you are not referring to the already existing incredibly extensive extensibility powers within NiFI but instead you are talking about 'we need to ensure extensions we build are themselves extensible'.
This becomes purely about how each component is written and designed. You can demonstrate and model what you'd like to see done to support this with components. In fact every author of a component should consider whether they want that thing extended by others but also the cost to the community to maintain such additional APIs.
Notably simply removing 'final' from a method or two does not do this. The extension developer has to consider whether they're going to make specific points of designed extensibility for a given component such that it might be open for extension but closed for modification. Or a totally different extensibility model where the extender could in fact break the thing. Whatever it is you as the author of the component get to choose that.
It would also be interesting to see or consider how such APIs would get published. We maintain the purity of the 'nifi-api' so you'd also then need to consider 'nifi-exampleprocessor-api-X.Y.Z' and so on. The moment you declare a component itself extensible you are declaring whatever its API is as public. Now you also cannot make changes without risking breaking code written against them.
I'll keep an eye out for a proposal or component where you share and show what you have in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3184582099
I can comment here or on the JIRA as preferred. The goal here is not clear.
Is the intent that by removing 'final' on these method signatures these components become open for extension? By whom?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "tpalfy (via GitHub)" <gi...@apache.org>.
tpalfy commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3187487777
@joewitt Yeah, the goal is to make it possible in general to create specialized processors based on the existing one by inheriting from them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3191533407
> @joewitt @exceptionfactory I can change the title and description of the Jira (the commit message is technical already). Although I think overall it would only be to NiFi's benefit if we considered components extensible.
Thanks, updating the Jira issue would be helpful for reference purposes.
Designing Processors for extension brings a much greater burden of complexity and maintainability, which is part of the reason that the classes themselves are not considered open for extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "tpalfy (via GitHub)" <gi...@apache.org>.
tpalfy commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3196366280
@joewitt I just want to create custom processors based on the existing ones. Add some properties, remove/re-default others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3189374459
> I definitely share what I think is your leaning here @exceptionfactory
>
> However, I think all this does is remove two generally pointless final declarations.
>
> It doesn't mean or imply we're saying this processor/set of processors are design for extension. They're really not.
>
> So with that very narrow view of what this I am +1 on this. You ok with that?
Thanks @joewitt, yes, with this background, I'm fine with the change in this particular PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3189364284
I definitely share what I think is your leaning here @exceptionfactory
However, I think all this does is remove two generally pointless final declarations.
It doesn't mean or imply we're saying this processor/set of processors are design for extension. They're really not.
So with that very narrow view of what this I am +1 on this. You ok with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14857 In ConsumeMQTT and PublishMQTT, remove 'final' keyword from 'getSupportedPropertyDescriptors()' method. [nifi]
Posted by "tpalfy (via GitHub)" <gi...@apache.org>.
tpalfy commented on PR #10200:
URL: https://github.com/apache/nifi/pull/10200#issuecomment-3191419720
@joewitt @exceptionfactory I can change the title and description of the Jira (the commit message is technical already). Although I think overall it would only be to NiFi's benefit if we considered components extensible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org