You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2019/07/18 17:57:41 UTC
Review Request 71118: Update clang and cmake for arm docker build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71118/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Update clang and cmake for arm docker build.
Diffs
-----
support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818
Diff: https://reviews.apache.org/r/71118/diff/1/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 71118: Update clang and cmake for arm docker build.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71118/#review216743
-----------------------------------------------------------
Fix it, then Ship it!
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 61-62 (patched)
<https://reviews.apache.org/r/71118/#comment303954>
Can we instead "properly" expand the tarball into the system prefix? Something like
$ cp -R clang+llvm-8.0.0-aarch64-linux-gnu/* /usr/
should work.
- Benjamin Bannier
On July 18, 2019, 7:57 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71118/
> -----------------------------------------------------------
>
> (Updated July 18, 2019, 7:57 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update clang and cmake for arm docker build.
>
>
> Diffs
> -----
>
> support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818
>
>
> Diff: https://reviews.apache.org/r/71118/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 71118: Update clang and cmake for arm docker build.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71118/#review216759
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71118]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 18, 2019, 7:17 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71118/
> -----------------------------------------------------------
>
> (Updated July 18, 2019, 7:17 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update clang and cmake for arm docker build.
>
>
> Diffs
> -----
>
> support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818
>
>
> Diff: https://reviews.apache.org/r/71118/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 71118: Update clang and cmake for arm docker build.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71118/
-----------------------------------------------------------
(Updated Lip 18, 2019, 7:17 po południu)
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Update clang and cmake for arm docker build.
Diffs (updated)
-----
support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818
Diff: https://reviews.apache.org/r/71118/diff/4/
Changes: https://reviews.apache.org/r/71118/diff/3-4/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 71118: Update clang and cmake for arm docker build.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71118/
-----------------------------------------------------------
(Updated Lip 18, 2019, 7:12 po południu)
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Update clang and cmake for arm docker build.
Diffs (updated)
-----
support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818
Diff: https://reviews.apache.org/r/71118/diff/3/
Changes: https://reviews.apache.org/r/71118/diff/2-3/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 71118: Update clang and cmake for arm docker build.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71118/
-----------------------------------------------------------
(Updated Lip 18, 2019, 7:09 po południu)
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Update clang and cmake for arm docker build.
Diffs (updated)
-----
support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818
Diff: https://reviews.apache.org/r/71118/diff/2/
Changes: https://reviews.apache.org/r/71118/diff/1-2/
Testing
-------
Thanks,
Tomasz Janiszewski