[jira] [Commented] (SAMZA-251) Add metrics for choose/process/window/commit/send time

["Yan Fang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087856#comment-14087856 ] 

Yan Fang commented on SAMZA-251:
--------------------------------

Hi Chris, thank you for reviewing.

Updated the patch based on your comment.

1) is done.
2) not quite sure how to use the trait here. Instead, create a function to do the same thing. Is this an acceptable implementation? 

Thank you.

RB: https://reviews.apache.org/r/23715/

> Add metrics for choose/process/window/commit/send time
> ------------------------------------------------------
>
>                 Key: SAMZA-251
>                 URL: https://issues.apache.org/jira/browse/SAMZA-251
>             Project: Samza
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Yan Fang
>              Labels: newbie
>             Fix For: 0.8.0
>
>         Attachments: SAMZA-251.1.patch, SAMZA-251.patch
>
>
> We should add the following counter metrics:
> * choose-ms
> * window-ms
> * process-ms
> * commit-ms
> * send-ms
> This will allow us to see how much time is being spent (per second) in each block of code.
> I think all of these metrics should be added at the SamzaContainer level, and all except choose-ms should be done at the TaskInstance level.



--
This message was sent by Atlassian JIRA
(v6.2#6252)