[jira] [Commented] (JCLOUDS-1441) [ARM] China regions can not be used

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605856#comment-16605856 ] 

ASF subversion and git services commented on JCLOUDS-1441:
----------------------------------------------------------

Commit 951b6b440334bc9ff76ee6fcad8520cd67e4dda3 in jclouds's branch refs/heads/2.1.x from Dani Estevez
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=951b6b4 ]

JCLOUDS-1441: Enables support for ARM regions in China

Adds new china regions

Fixes pattern matching for China provider oauth string

Modifies test for oauth string

overrides jclouds.oauth.resource property for tests

Graph and Vault API Endpoints need to be configurable

jclouds.oauth.resource is not mandatory

Adapted Endpoints for APIs GraphRBAC and Vault

Adds unit test for china oauth endpoint check

Minor fix to regular expression


> [ARM] China regions can not be used
> -----------------------------------
>
>                 Key: JCLOUDS-1441
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1441
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-compute
>            Reporter: Daniel Estevez
>            Assignee: Daniel Estevez
>            Priority: Major
>              Labels: Azure, azurecompute-arm
>             Fix For: 2.2.0
>
>
> Right now some paths are hardcoded, so azure compute provider cannot work correctly, this one was the main blocker:
> [https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/AzureComputeHttpApiModule.java#L57]
> As a reference, here is a documentation for the needed endpoint translations when using Azure regions in China [https://docs.microsoft.com/en-us/azure/china/china-get-started-developer-guide#check-endpoints-in-azure]
> Also some tests included configurations, regions and paths hardcoded that made it hard to test, i might open an alternate PR just to fix those tests executions.
> In a local branch overriding all those problems i could execute the full set of Live Tests with just two outstanding problems (maybe as different isolated issues):
>  * GraphAPI endpoint is hardcoded here [https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/GraphRBAC.java#L38]
>  * VaultAPI endpoints are also hardcoded https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/VaultApi.java#L149
>  
>  I will open a PR to fix those paths and allow the provider to work with China regions, as well as adding two missing regions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)